Re: [PATCH] phy: cpcap-usb: add MUSB dependency

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] phy: cpcap-usb: add MUSB dependency
Date	2017-06-12 10:10 +0200
Message-ID	<tRsA9-83t-7@gated-at.bofh.it> (permalink)
References	<tQpbk-h3-9@gated-at.bofh.it> <tQqAr-Yw-49@gated-at.bofh.it> <tQqTL-1lV-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Kishon Vijay Abraham I <kishon@ti.com> [170609 05:04]:
> 
> 
> On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
> >> When MUSB is a loadable module, we get a link error for a built-in
> >> CPCAP driver:
> >>
> >> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
> >> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
> >>
> >> This adds a Kconfig dependency to prevent this broken configuration,
> >> enforcing that CPCAP can only be a module when MUSB is also a module.
> >>
> >> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> 
> merged, thanks!

Yup thanks for fixing it.

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] phy: cpcap-usb: add MUSB dependency Arnd Bergmann <arnd@arndb.de> - 2017-06-09 12:20 +0200
  Re: [PATCH] phy: cpcap-usb: add MUSB dependency Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-06-09 13:50 +0200
    Re: [PATCH] phy: cpcap-usb: add MUSB dependency Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-09 14:10 +0200
      Re: [PATCH] phy: cpcap-usb: add MUSB dependency Tony Lindgren <tony@atomide.com> - 2017-06-12 10:10 +0200

csiph-web