Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1654067 > unrolled thread

[PATCH 1/2] power: reset: at91-poweroff: fix clobber list

Started byAlexandre Belloni <alexandre.belloni@free-electrons.com>
First post2017-05-31 11:50 +0200
Last post2017-06-07 23:00 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-31 11:50 +0200
    [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-31 11:50 +0200
      Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-06-01 11:10 +0200
      Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list Sebastian Reichel <sre@kernel.org> - 2017-06-07 23:00 +0200
    Re: [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-06-01 11:10 +0200
    Re: [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Sebastian Reichel <sre@kernel.org> - 2017-06-07 23:00 +0200

#1654067 — [PATCH 1/2] power: reset: at91-poweroff: fix clobber list

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-05-31 11:50 +0200
Subject[PATCH 1/2] power: reset: at91-poweroff: fix clobber list
Message-ID<tN8qm-31c-21@gated-at.bofh.it>
Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/power/reset/at91-poweroff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
index c6c3beea72f9..c30c40193aaa 100644
--- a/drivers/power/reset/at91-poweroff.c
+++ b/drivers/power/reset/at91-poweroff.c
@@ -97,7 +97,7 @@ static void at91_lpddr_poweroff(void)
 		  "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
 		  "r" (at91_shdwc_base),
 		  "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
-		: "r0");
+		: "r6");
 }
 
 static int at91_poweroff_get_wakeup_mode(struct device_node *np)
-- 
2.11.0

[toc] | [next] | [standalone]


#1654073 — [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-05-31 11:50 +0200
Subject[PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list
Message-ID<tN8qm-31c-33@gated-at.bofh.it>
In reply to#1654067
Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/power/reset/at91-sama5d2_shdwc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
index 90b0b5a70ce5..55fce8b75245 100644
--- a/drivers/power/reset/at91-sama5d2_shdwc.c
+++ b/drivers/power/reset/at91-sama5d2_shdwc.c
@@ -132,7 +132,7 @@ static void at91_lpddr_poweroff(void)
 		  "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
 		  "r" (at91_shdwc->at91_shdwc_base),
 		  "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
-		: "r0");
+		: "r6");
 }
 
 static u32 at91_shdwc_debouncer_value(struct platform_device *pdev,
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]


#1654945 — Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list

FromNicolas Ferre <nicolas.ferre@microchip.com>
Date2017-06-01 11:10 +0200
SubjectRe: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list
Message-ID<tNuhb-Bs-11@gated-at.bofh.it>
In reply to#1654073
Le 31/05/2017 à 11:49, Alexandre Belloni a écrit :
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
> 
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>  drivers/power/reset/at91-sama5d2_shdwc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index 90b0b5a70ce5..55fce8b75245 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -132,7 +132,7 @@ static void at91_lpddr_poweroff(void)
>  		  "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
>  		  "r" (at91_shdwc->at91_shdwc_base),
>  		  "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> -		: "r0");
> +		: "r6");
>  }
>  
>  static u32 at91_shdwc_debouncer_value(struct platform_device *pdev,
> 


-- 
Nicolas Ferre

[toc] | [prev] | [next] | [standalone]


#1660219 — Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list

FromSebastian Reichel <sre@kernel.org>
Date2017-06-07 23:00 +0200
SubjectRe: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list
Message-ID<tPQdB-38j-39@gated-at.bofh.it>
In reply to#1654073

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Wed, May 31, 2017 at 11:49:15AM +0200, Alexandre Belloni wrote:
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.

Thanks, queued.

-- Sebastian

> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/power/reset/at91-sama5d2_shdwc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index 90b0b5a70ce5..55fce8b75245 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -132,7 +132,7 @@ static void at91_lpddr_poweroff(void)
>  		  "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
>  		  "r" (at91_shdwc->at91_shdwc_base),
>  		  "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> -		: "r0");
> +		: "r6");
>  }
>  
>  static u32 at91_shdwc_debouncer_value(struct platform_device *pdev,
> -- 
> 2.11.0
> 

[toc] | [prev] | [next] | [standalone]


#1654951

FromNicolas Ferre <nicolas.ferre@microchip.com>
Date2017-06-01 11:10 +0200
Message-ID<tNuhc-Bs-37@gated-at.bofh.it>
In reply to#1654067
Le 31/05/2017 à 11:49, Alexandre Belloni a écrit :
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
> 
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>  drivers/power/reset/at91-poweroff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
> index c6c3beea72f9..c30c40193aaa 100644
> --- a/drivers/power/reset/at91-poweroff.c
> +++ b/drivers/power/reset/at91-poweroff.c
> @@ -97,7 +97,7 @@ static void at91_lpddr_poweroff(void)
>  		  "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
>  		  "r" (at91_shdwc_base),
>  		  "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> -		: "r0");
> +		: "r6");
>  }
>  
>  static int at91_poweroff_get_wakeup_mode(struct device_node *np)
> 


-- 
Nicolas Ferre

[toc] | [prev] | [next] | [standalone]


#1660207

FromSebastian Reichel <sre@kernel.org>
Date2017-06-07 23:00 +0200
Message-ID<tPQdz-38j-1@gated-at.bofh.it>
In reply to#1654067

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Wed, May 31, 2017 at 11:49:14AM +0200, Alexandre Belloni wrote:
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
> 
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Thanks, queued.

-- Sebastian

> ---
>  drivers/power/reset/at91-poweroff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
> index c6c3beea72f9..c30c40193aaa 100644
> --- a/drivers/power/reset/at91-poweroff.c
> +++ b/drivers/power/reset/at91-poweroff.c
> @@ -97,7 +97,7 @@ static void at91_lpddr_poweroff(void)
>  		  "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
>  		  "r" (at91_shdwc_base),
>  		  "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> -		: "r0");
> +		: "r6");
>  }
>  
>  static int at91_poweroff_get_wakeup_mode(struct device_node *np)
> -- 
> 2.11.0
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web