Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1654945

Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list

From Nicolas Ferre <nicolas.ferre@microchip.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list
Date 2017-06-01 11:10 +0200
Message-ID <tNuhb-Bs-11@gated-at.bofh.it> (permalink)
References <tN8qm-31c-21@gated-at.bofh.it> <tN8qm-31c-33@gated-at.bofh.it>
Organization microchip

Show all headers | View raw


Le 31/05/2017 à 11:49, Alexandre Belloni a écrit :
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
> 
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>  drivers/power/reset/at91-sama5d2_shdwc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index 90b0b5a70ce5..55fce8b75245 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -132,7 +132,7 @@ static void at91_lpddr_poweroff(void)
>  		  "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
>  		  "r" (at91_shdwc->at91_shdwc_base),
>  		  "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> -		: "r0");
> +		: "r6");
>  }
>  
>  static u32 at91_shdwc_debouncer_value(struct platform_device *pdev,
> 


-- 
Nicolas Ferre

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] power: reset: at91-poweroff: fix clobber list Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-31 11:50 +0200
  [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-31 11:50 +0200
    Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-06-01 11:10 +0200
  Re: [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-06-01 11:10 +0200

csiph-web