Re: [PATCH 1/2] power: reset: at91-poweroff: fix clobber list

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] power: reset: at91-poweroff: fix clobber list
Date	2017-06-07 23:00 +0200
Message-ID	<tPQdz-38j-1@gated-at.bofh.it> (permalink)
References	<tN8qm-31c-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, May 31, 2017 at 11:49:14AM +0200, Alexandre Belloni wrote:
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
> 
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Thanks, queued.

-- Sebastian

> ---
>  drivers/power/reset/at91-poweroff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
> index c6c3beea72f9..c30c40193aaa 100644
> --- a/drivers/power/reset/at91-poweroff.c
> +++ b/drivers/power/reset/at91-poweroff.c
> @@ -97,7 +97,7 @@ static void at91_lpddr_poweroff(void)
>  		  "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
>  		  "r" (at91_shdwc_base),
>  		  "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> -		: "r0");
> +		: "r6");
>  }
>  
>  static int at91_poweroff_get_wakeup_mode(struct device_node *np)
> -- 
> 2.11.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] power: reset: at91-poweroff: fix clobber list Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-31 11:50 +0200
  [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-31 11:50 +0200
    Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-06-01 11:10 +0200
    Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list Sebastian Reichel <sre@kernel.org> - 2017-06-07 23:00 +0200
  Re: [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-06-01 11:10 +0200
  Re: [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Sebastian Reichel <sre@kernel.org> - 2017-06-07 23:00 +0200

csiph-web