Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1644755 > unrolled thread

[PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

Started bySrinath Mannam <srinath.mannam@broadcom.com>
First post2017-05-18 19:00 +0200
Last post2017-05-22 18:30 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read Srinath Mannam <srinath.mannam@broadcom.com> - 2017-05-18 19:00 +0200
    Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Adrian Hunter <adrian.hunter@intel.com> - 2017-05-19 08:40 +0200
      Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Srinath Mannam <srinath.mannam@broadcom.com> - 2017-05-22 14:00 +0200
        Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Ulf Hansson <ulf.hansson@linaro.org> - 2017-05-22 14:10 +0200
          Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Srinath Mannam <srinath.mannam@broadcom.com> - 2017-05-22 15:40 +0200
            Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Ulf Hansson <ulf.hansson@linaro.org> - 2017-05-22 18:30 +0200

#1644755 — [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

FromSrinath Mannam <srinath.mannam@broadcom.com>
Date2017-05-18 19:00 +0200
Subject[PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
Message-ID<tIwWm-5mj-5@gated-at.bofh.it>
The stingray SDHCI hardware supports ACMD12 and automatically
issues after multi block transfer completed.

If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
on multi block read command with below error message:

Got data interrupt 0x00000002 even though no data
operation was in progress.

This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
ACM12 support in SDHCI hardware and suppress spurious interrupt.

Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>

diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 3275d49..61666d2 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -187,7 +187,8 @@ static const struct sdhci_iproc_data iproc_cygnus_data = {
 };
 
 static const struct sdhci_pltfm_data sdhci_iproc_pltfm_data = {
-	.quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK,
+	.quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
+		  SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
 	.quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN,
 	.ops = &sdhci_iproc_ops,
 };
-- 
2.7.4

[toc] | [next] | [standalone]

#1645223 — Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

FromAdrian Hunter <adrian.hunter@intel.com>
Date2017-05-19 08:40 +0200
SubjectRe: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
Message-ID<tIJJT-6HC-1@gated-at.bofh.it>
In reply to#1644755
On 18/05/17 19:57, Srinath Mannam wrote:
> The stingray SDHCI hardware supports ACMD12 and automatically
> issues after multi block transfer completed.
> 
> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
> on multi block read command with below error message:
> 
> Got data interrupt 0x00000002 even though no data
> operation was in progress.
> 
> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
> ACM12 support in SDHCI hardware and suppress spurious interrupt.
> 
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> 
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 3275d49..61666d2 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -187,7 +187,8 @@ static const struct sdhci_iproc_data iproc_cygnus_data = {
>  };
>  
>  static const struct sdhci_pltfm_data sdhci_iproc_pltfm_data = {
> -	.quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK,
> +	.quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
> +		  SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
>  	.quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN,
>  	.ops = &sdhci_iproc_ops,
>  };
>

[toc] | [prev] | [next] | [standalone]

#1646796 — Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

FromSrinath Mannam <srinath.mannam@broadcom.com>
Date2017-05-22 14:00 +0200
SubjectRe: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
Message-ID<tJUaf-5dJ-45@gated-at.bofh.it>
In reply to#1645223
On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 18/05/17 19:57, Srinath Mannam wrote:
>> The stingray SDHCI hardware supports ACMD12 and automatically
>> issues after multi block transfer completed.
>>
>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>> on multi block read command with below error message:
>>
>> Got data interrupt 0x00000002 even though no data
>> operation was in progress.
>>
>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>
>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>

Thanks Adrian...

Will it be possible to take this for Linux-4.12??

Regards,
Srinath

[toc] | [prev] | [next] | [standalone]

#1646798 — Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-05-22 14:10 +0200
SubjectRe: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
Message-ID<tJUjU-5vZ-5@gated-at.bofh.it>
In reply to#1646796
On 22 May 2017 at 13:52, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
> On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>> On 18/05/17 19:57, Srinath Mannam wrote:
>>> The stingray SDHCI hardware supports ACMD12 and automatically
>>> issues after multi block transfer completed.
>>>
>>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>>> on multi block read command with below error message:
>>>
>>> Got data interrupt 0x00000002 even though no data
>>> operation was in progress.
>>>
>>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>>
>>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
>>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>>
>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Thanks Adrian...
>
> Will it be possible to take this for Linux-4.12??

It's queued for 4.13, however are you saying it's a regression for
4.12? Then what commit fixes it?

Perhaps you even want this to go stable?

Kind regards
Uffe

[toc] | [prev] | [next] | [standalone]

#1646900 — Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

FromSrinath Mannam <srinath.mannam@broadcom.com>
Date2017-05-22 15:40 +0200
SubjectRe: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
Message-ID<tJVJ0-6iD-13@gated-at.bofh.it>
In reply to#1646798
On Mon, May 22, 2017 at 5:31 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 22 May 2017 at 13:52, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
>> On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>> On 18/05/17 19:57, Srinath Mannam wrote:
>>>> The stingray SDHCI hardware supports ACMD12 and automatically
>>>> issues after multi block transfer completed.
>>>>
>>>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>>>> on multi block read command with below error message:
>>>>
>>>> Got data interrupt 0x00000002 even though no data
>>>> operation was in progress.
>>>>
>>>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>>>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>>>
>>>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
>>>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>>>
>>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>>
>> Thanks Adrian...
>>
>> Will it be possible to take this for Linux-4.12??
>
> It's queued for 4.13, however are you saying it's a regression for
> 4.12? Then what commit fixes it?
>
> Perhaps you even want this to go stable?
>
> Kind regards
> Uffe

Yes, this is regression for 4.12.
Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
Yes we want this to go in stable.

Thank you.

Regards,
Srinath.

[toc] | [prev] | [next] | [standalone]

#1647116 — Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-05-22 18:30 +0200
SubjectRe: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
Message-ID<tJYnw-80c-39@gated-at.bofh.it>
In reply to#1646900
On 22 May 2017 at 15:33, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
> On Mon, May 22, 2017 at 5:31 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> On 22 May 2017 at 13:52, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
>>> On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>>> On 18/05/17 19:57, Srinath Mannam wrote:
>>>>> The stingray SDHCI hardware supports ACMD12 and automatically
>>>>> issues after multi block transfer completed.
>>>>>
>>>>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>>>>> on multi block read command with below error message:
>>>>>
>>>>> Got data interrupt 0x00000002 even though no data
>>>>> operation was in progress.
>>>>>
>>>>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>>>>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>>>>
>>>>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
>>>>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>>>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>>>>
>>>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>>>
>>> Thanks Adrian...
>>>
>>> Will it be possible to take this for Linux-4.12??
>>
>> It's queued for 4.13, however are you saying it's a regression for
>> 4.12? Then what commit fixes it?
>>
>> Perhaps you even want this to go stable?
>>
>> Kind regards
>> Uffe
>
> Yes, this is regression for 4.12.
> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
> Yes we want this to go in stable.
>

Alright, applied for fixes and added a stable tag.

Kind regards
Uffe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web