Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
Date	2017-05-22 18:30 +0200
Message-ID	<tJYnw-80c-39@gated-at.bofh.it> (permalink)
References	<tIwWm-5mj-5@gated-at.bofh.it> <tIJJT-6HC-1@gated-at.bofh.it> <tJUaf-5dJ-45@gated-at.bofh.it> <tJUjU-5vZ-5@gated-at.bofh.it> <tJVJ0-6iD-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 22 May 2017 at 15:33, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
> On Mon, May 22, 2017 at 5:31 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> On 22 May 2017 at 13:52, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
>>> On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>>> On 18/05/17 19:57, Srinath Mannam wrote:
>>>>> The stingray SDHCI hardware supports ACMD12 and automatically
>>>>> issues after multi block transfer completed.
>>>>>
>>>>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>>>>> on multi block read command with below error message:
>>>>>
>>>>> Got data interrupt 0x00000002 even though no data
>>>>> operation was in progress.
>>>>>
>>>>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>>>>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>>>>
>>>>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
>>>>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>>>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>>>>
>>>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>>>
>>> Thanks Adrian...
>>>
>>> Will it be possible to take this for Linux-4.12??
>>
>> It's queued for 4.13, however are you saying it's a regression for
>> 4.12? Then what commit fixes it?
>>
>> Perhaps you even want this to go stable?
>>
>> Kind regards
>> Uffe
>
> Yes, this is regression for 4.12.
> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
> Yes we want this to go in stable.
>

Alright, applied for fixes and added a stable tag.

Kind regards
Uffe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read Srinath Mannam <srinath.mannam@broadcom.com> - 2017-05-18 19:00 +0200
  Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Adrian Hunter <adrian.hunter@intel.com> - 2017-05-19 08:40 +0200
    Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Srinath Mannam <srinath.mannam@broadcom.com> - 2017-05-22 14:00 +0200
      Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Ulf Hansson <ulf.hansson@linaro.org> - 2017-05-22 14:10 +0200
        Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Srinath Mannam <srinath.mannam@broadcom.com> - 2017-05-22 15:40 +0200
          Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Ulf Hansson <ulf.hansson@linaro.org> - 2017-05-22 18:30 +0200

csiph-web