Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1644755

[PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

Show all headers | View raw

The stingray SDHCI hardware supports ACMD12 and automatically
issues after multi block transfer completed.

If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
on multi block read command with below error message:

Got data interrupt 0x00000002 even though no data
operation was in progress.

This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
ACM12 support in SDHCI hardware and suppress spurious interrupt.

Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>

diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 3275d49..61666d2 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -187,7 +187,8 @@ static const struct sdhci_iproc_data iproc_cygnus_data = {
 };
 
 static const struct sdhci_pltfm_data sdhci_iproc_pltfm_data = {
-	.quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK,
+	.quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
+		  SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
 	.quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN,
 	.ops = &sdhci_iproc_ops,
 };
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read Srinath Mannam <srinath.mannam@broadcom.com> - 2017-05-18 19:00 +0200
  Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Adrian Hunter <adrian.hunter@intel.com> - 2017-05-19 08:40 +0200
    Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Srinath Mannam <srinath.mannam@broadcom.com> - 2017-05-22 14:00 +0200
      Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Ulf Hansson <ulf.hansson@linaro.org> - 2017-05-22 14:10 +0200
        Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Srinath Mannam <srinath.mannam@broadcom.com> - 2017-05-22 15:40 +0200
          Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with  Multiblock read Ulf Hansson <ulf.hansson@linaro.org> - 2017-05-22 18:30 +0200

csiph-web