Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1641332 > unrolled thread
| Started by | Mark Brown <broonie@kernel.org> |
|---|---|
| First post | 2017-05-15 10:00 +0200 |
| Last post | 2017-05-15 13:00 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Mark Brown <broonie@kernel.org> - 2017-05-15 10:00 +0200
Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-15 10:50 +0200
Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Mark Brown <broonie@kernel.org> - 2017-05-15 12:20 +0200
Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-15 12:30 +0200
Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Mark Brown <broonie@kernel.org> - 2017-05-15 13:00 +0200
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-05-15 10:00 +0200 |
| Subject | Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA |
| Message-ID | <tHj58-5aS-7@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined! > > Add a dependency on HAS_DMA to fix this. There's no progress on fixing the architectures that don't do DMA to stub it out? :(
[toc] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2017-05-15 10:50 +0200 |
| Message-ID | <tHjRw-5Kw-11@gated-at.bofh.it> |
| In reply to | #1641332 |
Hi Mark,
On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote:
> On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote:
>> If NO_DMA=y:
>>
>> ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!
>>
>> Add a dependency on HAS_DMA to fix this.
>
> There's no progress on fixing the architectures that don't do DMA to
> stub it out? :(
Then it has to become "depends on HAS_DMA || COMPILE_TEST"?
Even more typing work for me ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-05-15 12:20 +0200 |
| Message-ID | <tHlgC-6Pc-27@gated-at.bofh.it> |
| In reply to | #1641395 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, May 15, 2017 at 10:46:15AM +0200, Geert Uytterhoeven wrote: > On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote: > > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote: > >> If NO_DMA=y: > >> ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined! > >> Add a dependency on HAS_DMA to fix this. > > There's no progress on fixing the architectures that don't do DMA to > > stub it out? :( > Then it has to become "depends on HAS_DMA || COMPILE_TEST"? No, I was thinking more just not needing the dependency at all.
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2017-05-15 12:30 +0200 |
| Message-ID | <tHlqi-6SH-15@gated-at.bofh.it> |
| In reply to | #1641515 |
Hi Mark,
On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, May 15, 2017 at 10:46:15AM +0200, Geert Uytterhoeven wrote:
>> On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote:
>> > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote:
>> >> If NO_DMA=y:
>
>> >> ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!
>
>> >> Add a dependency on HAS_DMA to fix this.
>
>> > There's no progress on fixing the architectures that don't do DMA to
>> > stub it out? :(
>
>> Then it has to become "depends on HAS_DMA || COMPILE_TEST"?
>
> No, I was thinking more just not needing the dependency at all.
Then what's the point of the existence of COMPILE_TEST?
We can just have stubs for everything, and always build everything.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-05-15 13:00 +0200 |
| Message-ID | <tHlTk-72L-21@gated-at.bofh.it> |
| In reply to | #1641522 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, May 15, 2017 at 12:21:33PM +0200, Geert Uytterhoeven wrote: > On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote: > > No, I was thinking more just not needing the dependency at all. > Then what's the point of the existence of COMPILE_TEST? > We can just have stubs for everything, and always build everything. It's useful for platform specific devices (like this one should be) but having to add dependencies for basic kernel APIs like the DMA one is just making for a lot of noise. There's plenty of platforms without DMA that also have no real use for this driver, it's not really a relevant thing when deciding if the driver might be useful if what you're trying to do is hide drivers that aren't useful on the platform.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web