Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1641522

Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

From Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups linux.kernel
Subject Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA
Date 2017-05-15 12:30 +0200
Message-ID <tHlqi-6SH-15@gated-at.bofh.it> (permalink)
References <tDjQ6-um-5@gated-at.bofh.it> <tHj58-5aS-7@gated-at.bofh.it> <tHjRw-5Kw-11@gated-at.bofh.it> <tHlgC-6Pc-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Mark,

On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, May 15, 2017 at 10:46:15AM +0200, Geert Uytterhoeven wrote:
>> On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote:
>> > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote:
>> >> If NO_DMA=y:
>
>> >>     ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!
>
>> >> Add a dependency on HAS_DMA to fix this.
>
>> > There's no progress on fixing the architectures that don't do DMA to
>> > stub it out?  :(
>
>> Then it has to become "depends on HAS_DMA || COMPILE_TEST"?
>
> No, I was thinking more just not needing the dependency at all.

Then what's the point of the existence of COMPILE_TEST?
We can just have stubs for everything, and always build everything.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Mark Brown <broonie@kernel.org> - 2017-05-15 10:00 +0200
  Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-15 10:50 +0200
    Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Mark Brown <broonie@kernel.org> - 2017-05-15 12:20 +0200
      Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-15 12:30 +0200
        Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Mark Brown <broonie@kernel.org> - 2017-05-15 13:00 +0200

csiph-web