Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA
Date	2017-05-15 13:00 +0200
Message-ID	<tHlTk-72L-21@gated-at.bofh.it> (permalink)
References	<tDjQ6-um-5@gated-at.bofh.it> <tHj58-5aS-7@gated-at.bofh.it> <tHjRw-5Kw-11@gated-at.bofh.it> <tHlgC-6Pc-27@gated-at.bofh.it> <tHlqi-6SH-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, May 15, 2017 at 12:21:33PM +0200, Geert Uytterhoeven wrote:
> On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote:

> > No, I was thinking more just not needing the dependency at all.

> Then what's the point of the existence of COMPILE_TEST?
> We can just have stubs for everything, and always build everything.

It's useful for platform specific devices (like this one should be) but
having to add dependencies for basic kernel APIs like the DMA one is
just making for a lot of noise.  There's plenty of platforms without DMA
that also have no real use for this driver, it's not really a relevant
thing when deciding if the driver might be useful if what you're trying
to do is hide drivers that aren't useful on the platform.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Mark Brown <broonie@kernel.org> - 2017-05-15 10:00 +0200
  Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-15 10:50 +0200
    Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Mark Brown <broonie@kernel.org> - 2017-05-15 12:20 +0200
      Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-15 12:30 +0200
        Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA Mark Brown <broonie@kernel.org> - 2017-05-15 13:00 +0200

csiph-web