Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1638061 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-05-09 14:00 +0200 |
| Last post | 2017-05-10 09:00 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/4] net: stmmac: Fine-tuning for four function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
[PATCH 1/4] net: stmmac: Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
[PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
[PATCH 3/4] net: stmmac: Use seq_putc() in sysfs_display_ring() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
Re: [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-05-10 09:00 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-09 14:00 +0200 |
| Subject | [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations |
| Message-ID | <tFbY5-1dU-5@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 9 May 2017 13:48:03 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read() Replace five seq_printf() calls by seq_puts() Use seq_putc() in sysfs_display_ring() Delete an unnecessary return statement in stmmac_get_tx_hwtstamp() drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) -- 2.12.2
[toc] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-09 14:00 +0200 |
| Subject | [PATCH 1/4] net: stmmac: Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read() |
| Message-ID | <tFbY5-1dU-7@gated-at.bofh.it> |
| In reply to | #1638061 |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 9 May 2017 13:10:28 +0200 A bit of text was put into a sequence by three separate function calls. Print the same data by a single function call instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index cd8c60132390..2949c9fc18fa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3802,10 +3802,10 @@ static int stmmac_sysfs_dma_cap_read(struct seq_file *seq, void *v) return 0; } - seq_printf(seq, "==============================\n"); - seq_printf(seq, "\tDMA HW features\n"); - seq_printf(seq, "==============================\n"); - + seq_puts(seq, + "==============================\n" + "\tDMA HW features\n" + "==============================\n"); seq_printf(seq, "\t10/100 Mbps: %s\n", (priv->dma_cap.mbps_10_100) ? "Y" : "N"); seq_printf(seq, "\t1000 Mbps: %s\n", -- 2.12.2
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-09 14:00 +0200 |
| Subject | [PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp() |
| Message-ID | <tFbY5-1dU-9@gated-at.bofh.it> |
| In reply to | #1638061 |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 9 May 2017 13:36:04 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected function. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 4fa95234978c..9ab4cbfa67f1 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -445,8 +445,6 @@ static void stmmac_get_tx_hwtstamp(struct stmmac_priv *priv, /* pass tstamp to stack */ skb_tstamp_tx(skb, &shhwtstamp); } - - return; } /* stmmac_get_rx_hwtstamp - get HW RX timestamps -- 2.12.2
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-09 14:00 +0200 |
| Subject | [PATCH 3/4] net: stmmac: Use seq_putc() in sysfs_display_ring() |
| Message-ID | <tFbY5-1dU-13@gated-at.bofh.it> |
| In reply to | #1638061 |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 9 May 2017 13:24:27 +0200 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 1f7022ce78b7..4fa95234978c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3730,7 +3730,7 @@ static void sysfs_display_ring(void *head, int size, int extend_desc, le32_to_cpu(p->des2), le32_to_cpu(p->des3)); p++; } - seq_printf(seq, "\n"); + seq_putc(seq, '\n'); } } -- 2.12.2
[toc] | [prev] | [next] | [standalone]
| From | Giuseppe CAVALLARO <peppe.cavallaro@st.com> |
|---|---|
| Date | 2017-05-10 09:00 +0200 |
| Message-ID | <tFtLj-5MF-17@gated-at.bofh.it> |
| In reply to | #1638061 |
Hello Markus Thanks a lot for your effort on stmmac On 5/9/2017 1:51 PM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 9 May 2017 13:48:03 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (4): > Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read() > Replace five seq_printf() calls by seq_puts() > Use seq_putc() in sysfs_display_ring() > Delete an unnecessary return statement in stmmac_get_tx_hwtstamp() > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web