Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639538 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2017-05-11 16:30 +0200 |
| Last post | 2017-05-12 15:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-11 16:30 +0200
Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry() Ben Hutchings <ben.hutchings@codethink.co.uk> - 2017-05-12 13:40 +0200
Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-12 15:20 +0200
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-11 16:30 +0200 |
| Subject | [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry() |
| Message-ID | <tFXgm-7ta-33@gated-at.bofh.it> |
4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Carpenter <dan.carpenter@oracle.com>
commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream.
We accidentally return an uninitialized variable on success.
Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/scsi/device_handler/scsi_dh_emc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/device_handler/scsi_dh_emc.c
+++ b/drivers/scsi/device_handler/scsi_dh_emc.c
@@ -456,7 +456,7 @@ static int clariion_prep_fn(struct scsi_
static int clariion_std_inquiry(struct scsi_device *sdev,
struct clariion_dh_data *csdev)
{
- int err;
+ int err = SCSI_DH_OK;
char *sp_model;
err = send_inquiry_cmd(sdev, 0, csdev);
[toc] | [next] | [standalone]
| From | Ben Hutchings <ben.hutchings@codethink.co.uk> |
|---|---|
| Date | 2017-05-12 13:40 +0200 |
| Subject | Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry() |
| Message-ID | <tGh5n-3PS-9@gated-at.bofh.it> |
| In reply to | #1639538 |
On Thu, 2017-05-11 at 16:13 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream.
>
> We accidentally return an uninitialized variable on success.
No we don't.
> Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
Actually fixes: b78205c93297 ("scsi_dh_emc: switch to
scsi_execute_req_flags()") so this is only needed for 4.11.y.
Ben.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> drivers/scsi/device_handler/scsi_dh_emc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/scsi/device_handler/scsi_dh_emc.c
> +++ b/drivers/scsi/device_handler/scsi_dh_emc.c
> @@ -456,7 +456,7 @@ static int clariion_prep_fn(struct scsi_
> static int clariion_std_inquiry(struct scsi_device *sdev,
> struct clariion_dh_data *csdev)
> {
> - int err;
> + int err = SCSI_DH_OK;
> char *sp_model;
>
> err = send_inquiry_cmd(sdev, 0, csdev);
>
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-12 15:20 +0200 |
| Subject | Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry() |
| Message-ID | <tGiE9-52n-5@gated-at.bofh.it> |
| In reply to | #1640403 |
On Fri, May 12, 2017 at 12:36:13PM +0100, Ben Hutchings wrote:
> On Thu, 2017-05-11 at 16:13 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream.
> >
> > We accidentally return an uninitialized variable on success.
>
> No we don't.
>
> > Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
>
> Actually fixes: b78205c93297 ("scsi_dh_emc: switch to
> scsi_execute_req_flags()") so this is only needed for 4.11.y.
Ah, thanks for catching this, removed now from all of the queues.
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web