[PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	[PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry()
Date	2017-05-11 16:30 +0200
Message-ID	<tFXgm-7ta-33@gated-at.bofh.it> (permalink)
References	<tFXgl-7ta-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Dan Carpenter <dan.carpenter@oracle.com>

commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream.

We accidentally return an uninitialized variable on success.

Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/scsi/device_handler/scsi_dh_emc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/scsi/device_handler/scsi_dh_emc.c
+++ b/drivers/scsi/device_handler/scsi_dh_emc.c
@@ -456,7 +456,7 @@ static int clariion_prep_fn(struct scsi_
 static int clariion_std_inquiry(struct scsi_device *sdev,
 				struct clariion_dh_data *csdev)
 {
-	int err;
+	int err = SCSI_DH_OK;
 	char *sp_model;
 
 	err = send_inquiry_cmd(sdev, 0, csdev);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-11 16:30 +0200
  Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in  clariion_std_inquiry() Ben Hutchings <ben.hutchings@codethink.co.uk> - 2017-05-12 13:40 +0200
    Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in  clariion_std_inquiry() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-12 15:20 +0200

csiph-web