Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry()
Date	2017-05-12 15:20 +0200
Message-ID	<tGiE9-52n-5@gated-at.bofh.it> (permalink)
References	<tFXgl-7ta-3@gated-at.bofh.it> <tFXgm-7ta-33@gated-at.bofh.it> <tGh5n-3PS-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 12, 2017 at 12:36:13PM +0100, Ben Hutchings wrote:
> On Thu, 2017-05-11 at 16:13 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream.
> > 
> > We accidentally return an uninitialized variable on success.
> 
> No we don't.
> 
> > Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
> 
> Actually fixes: b78205c93297 ("scsi_dh_emc: switch to
> scsi_execute_req_flags()") so this is only needed for 4.11.y.

Ah, thanks for catching this, removed now from all of the queues.

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-11 16:30 +0200
  Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in  clariion_std_inquiry() Ben Hutchings <ben.hutchings@codethink.co.uk> - 2017-05-12 13:40 +0200
    Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in  clariion_std_inquiry() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-12 15:20 +0200

csiph-web