Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634289 > unrolled thread

[PATCH 0/9] pinctrl: Fine-tuning for some function implementations

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
    [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
      Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 19:50 +0200
      Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() Linus Walleij <linus.walleij@linaro.org> - 2017-05-11 15:30 +0200
    [PATCH 6/9] pinctrl: Combine substrings for a message in  pin_config_group_get() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
      Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 20:00 +0200
      Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() Linus Walleij <linus.walleij@linaro.org> - 2017-05-11 15:30 +0200
    [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in  two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
      Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call  in two functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 19:50 +0200

#1634289 — [PATCH 0/9] pinctrl: Fine-tuning for some function implementations

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 11:16:54 +0200

Some update suggestions were taken into account
from static source code analysis.

Markus Elfring (9):
  Use seq_putc() in three functions
  Combine two seq_puts() calls into one call in two functions
  Combine five seq_printf() calls into one call in pinconf_dbg_config_print()
  Replace two seq_printf() calls by seq_puts() in pinconf_show_map()
  Adjust five checks for null pointers
  Combine substrings for a message in pin_config_group_get()
  Add spaces for better code readability
  core: Use seq_putc() in pinctrl_maps_show()
  core: Adjust nine checks for null pointers

 drivers/pinctrl/core.c    | 20 ++++++++--------
 drivers/pinctrl/pinconf.c | 61 ++++++++++++++++++++++++-----------------------
 2 files changed, 41 insertions(+), 40 deletions(-)

-- 
2.12.2

[toc] | [next] | [standalone]

#1634290 — [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 10:47:35 +0200

A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/pinctrl/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 1653cbda6a82..7df16771fa13 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1732,7 +1732,7 @@ static int pinctrl_maps_show(struct seq_file *s, void *what)
 			break;
 		}
 
-		seq_printf(s, "\n");
+		seq_putc(s, '\n');
 	}
 	mutex_unlock(&pinctrl_maps_mutex);
 
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1635176 — Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show()

On Tue, May 2, 2017 at 12:28 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:47:35 +0200
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".

This could be folded to another one with similar changes.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1639432 — Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show()

On Tue, May 2, 2017 at 11:28 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:47:35 +0200
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Patch applied.

Maybe I will coalesce it with other commits as Andy suggests.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1634291 — [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 10:22:47 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: quoted string split across lines

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/pinctrl/pinconf.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index f2168b6e3418..037ac3e47891 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -87,9 +87,8 @@ int pin_config_group_get(const char *dev_name, const char *pin_group,
 	ops = pctldev->desc->confops;
 
 	if (!ops || !ops->pin_config_group_get) {
-		dev_dbg(pctldev->dev, "cannot get configuration for pin "
-			"group, missing group config get function in "
-			"driver\n");
+		dev_dbg(pctldev->dev,
+			"cannot get configuration for pin group, missing group config get function in driver\n");
 		ret = -ENOTSUPP;
 		goto unlock;
 	}
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1635180 — Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get()

On Tue, May 2, 2017 at 12:26 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:22:47 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: quoted string split across lines
>
> Thus fix the affected source code place.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/pinctrl/pinconf.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
> index f2168b6e3418..037ac3e47891 100644
> --- a/drivers/pinctrl/pinconf.c
> +++ b/drivers/pinctrl/pinconf.c
> @@ -87,9 +87,8 @@ int pin_config_group_get(const char *dev_name, const char *pin_group,
>         ops = pctldev->desc->confops;
>
>         if (!ops || !ops->pin_config_group_get) {
> -               dev_dbg(pctldev->dev, "cannot get configuration for pin "
> -                       "group, missing group config get function in "
> -                       "driver\n");
> +               dev_dbg(pctldev->dev,
> +                       "cannot get configuration for pin group, missing group config get function in driver\n");
>                 ret = -ENOTSUPP;
>                 goto unlock;
>         }
> --
> 2.12.2
>



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1639429 — Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get()

On Tue, May 2, 2017 at 11:26 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:22:47 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: quoted string split across lines
>
> Thus fix the affected source code place.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1634292 — [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 May 2017 22:42:13 +0200

Some text was put into a sequence by two separate function calls.
Print the same data by a single function call instead.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/pinctrl/pinconf.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 1a3fbdf81ecb..a14ae8601b39 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -307,9 +307,9 @@ static int pinconf_pins_show(struct seq_file *s, void *what)
 	struct pinctrl_dev *pctldev = s->private;
 	unsigned i, pin;
 
-	seq_puts(s, "Pin config settings per pin\n");
-	seq_puts(s, "Format: pin (name): configs\n");
-
+	seq_puts(s,
+		 "Pin config settings per pin\n"
+		 "Format: pin (name): configs\n");
 	mutex_lock(&pctldev->mutex);
 
 	/* The pin number can be retrived from the pin controller descriptor */
@@ -352,8 +352,9 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
 	unsigned ngroups = pctlops->get_groups_count(pctldev);
 	unsigned selector = 0;
 
-	seq_puts(s, "Pin config settings per pin group\n");
-	seq_puts(s, "Format: group (name): configs\n");
+	seq_puts(s,
+		 "Pin config settings per pin group\n"
+		 "Format: group (name): configs\n");
 
 	while (selector < ngroups) {
 		const char *gname = pctlops->get_group_name(pctldev, selector);
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1635173 — Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions

On Tue, May 2, 2017 at 12:22 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 22:42:13 +0200
>
> Some text was put into a sequence by two separate function calls.
> Print the same data by a single function call instead.

I don't see a benefit here, sorry.
This is slow path in any case (printing is slow). Currently code is
neat, you do it slightly harder to parse.


-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web