Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635180

Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get()

Show all headers | View raw

On Tue, May 2, 2017 at 12:26 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:22:47 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: quoted string split across lines
>
> Thus fix the affected source code place.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/pinctrl/pinconf.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
> index f2168b6e3418..037ac3e47891 100644
> --- a/drivers/pinctrl/pinconf.c
> +++ b/drivers/pinctrl/pinconf.c
> @@ -87,9 +87,8 @@ int pin_config_group_get(const char *dev_name, const char *pin_group,
>         ops = pctldev->desc->confops;
>
>         if (!ops || !ops->pin_config_group_get) {
> -               dev_dbg(pctldev->dev, "cannot get configuration for pin "
> -                       "group, missing group config get function in "
> -                       "driver\n");
> +               dev_dbg(pctldev->dev,
> +                       "cannot get configuration for pin group, missing group config get function in driver\n");
>                 ret = -ENOTSUPP;
>                 goto unlock;
>         }
> --
> 2.12.2
>



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
  [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
    Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 19:50 +0200
    Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() Linus Walleij <linus.walleij@linaro.org> - 2017-05-11 15:30 +0200
  [PATCH 6/9] pinctrl: Combine substrings for a message in  pin_config_group_get() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
    Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 20:00 +0200
    Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() Linus Walleij <linus.walleij@linaro.org> - 2017-05-11 15:30 +0200
  [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in  two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
    Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call  in two functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 19:50 +0200

csiph-web