Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions
Date	2017-05-03 19:50 +0200
Message-ID	<tD6zw-8vy-7@gated-at.bofh.it> (permalink)
References	<tCCi5-4Jn-5@gated-at.bofh.it> <tCCi7-4Jn-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 2, 2017 at 12:22 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 22:42:13 +0200
>
> Some text was put into a sequence by two separate function calls.
> Print the same data by a single function call instead.

I don't see a benefit here, sorry.
This is slow path in any case (printing is slow). Currently code is
neat, you do it slightly harder to parse.


-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
  [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
    Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 19:50 +0200
    Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() Linus Walleij <linus.walleij@linaro.org> - 2017-05-11 15:30 +0200
  [PATCH 6/9] pinctrl: Combine substrings for a message in  pin_config_group_get() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
    Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 20:00 +0200
    Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() Linus Walleij <linus.walleij@linaro.org> - 2017-05-11 15:30 +0200
  [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in  two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
    Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call  in two functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 19:50 +0200

csiph-web