Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561989 > unrolled thread

[PATCH] firmware/Makefile: force recompilation if makefile changes

Back to article view | Back to linux.kernel

Contents

  [PATCH] firmware/Makefile: force recompilation if makefile changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-18 18:40 +0100
    Re: [PATCH] firmware/Makefile: force recompilation if makefile  changes Greg KH <gregkh@linuxfoundation.org> - 2017-01-19 11:30 +0100
      Re: [PATCH] firmware/Makefile: force recompilation if makefile  changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-23 16:10 +0100
        Re: [PATCH] firmware/Makefile: force recompilation if makefile changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-23 16:10 +0100
        Re: [PATCH] firmware/Makefile: force recompilation if makefile  changes Greg KH <gregkh@linuxfoundation.org> - 2017-01-23 16:10 +0100
    [PATCH v2] firmware/Makefile: force recompilation if makefile changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-23 16:10 +0100

#1561989 — [PATCH] firmware/Makefile: force recompilation if makefile changes

If you modify the target asm we currently do not force the
recompilation of the firmware files. The target asm is in
the firmware/Makefile, peg this file as a dependency to
require re-compilation of firmware targets when the asm
changes.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---

Greg,

This was part of the linker table series [0], but I'm going to split up
patches further there. This is an atomic change which is independent
so sending this separately now.

[0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org

 firmware/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/firmware/Makefile b/firmware/Makefile
index e297e1b52636..fa3e81c2a97b 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW   $@
 wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \
 		include/config/ppc32.h include/config/ppc64.h \
 		include/config/superh32.h include/config/superh64.h \
-		include/config/x86_32.h include/config/x86_64.h)
+		include/config/x86_32.h include/config/x86_64.h \
+		firmware/Makefile)
 
 $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps)
 	$(call cmd,fwbin,$(patsubst %.gen.S,%,$@))
-- 
2.11.0

[toc] | [next] | [standalone]

#1562564 — Re: [PATCH] firmware/Makefile: force recompilation if makefile changes

On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote:
> If you modify the target asm we currently do not force the
> recompilation of the firmware files. The target asm is in
> the firmware/Makefile, peg this file as a dependency to
> require re-compilation of firmware targets when the asm
> changes.

Why would changing the Makefile require the asm to change?

Anyway, this should go through the kbuild tree, not mine, they know
Makefiles much better than I do...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1565024 — Re: [PATCH] firmware/Makefile: force recompilation if makefile changes

On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote:
> On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote:
> > If you modify the target asm we currently do not force the
> > recompilation of the firmware files. The target asm is in
> > the firmware/Makefile, peg this file as a dependency to
> > require re-compilation of firmware targets when the asm
> > changes.
> 
> Why would changing the Makefile require the asm to change?

The Makefile is the file that provides the assembly logic, so
changing the asm should affect recreating the binary.

> Anyway, this should go through the kbuild tree, not mine, they know
> Makefiles much better than I do...

Will send it there. Thanks.

  Luis

[toc] | [prev] | [next] | [standalone]

#1565031

On Mon, Jan 23, 2017 at 9:02 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Jan 23, 2017 at 03:59:52PM +0100, Luis R. Rodriguez wrote:
>> On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote:
>> > On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote:
>> > > If you modify the target asm we currently do not force the
>> > > recompilation of the firmware files. The target asm is in
>> > > the firmware/Makefile, peg this file as a dependency to
>> > > require re-compilation of firmware targets when the asm
>> > > changes.
>> >
>> > Why would changing the Makefile require the asm to change?
>>
>> The Makefile is the file that provides the assembly logic, so
>> changing the asm should affect recreating the binary.
>
> Ah, I see it now, that's horrid, echoing asm from the Makefile itself :)

Yeah, I can change the way that works but I think I would much prefer
to make that a separate atomic functional change.

  Luis

[toc] | [prev] | [next] | [standalone]

#1565035 — Re: [PATCH] firmware/Makefile: force recompilation if makefile changes

On Mon, Jan 23, 2017 at 03:59:52PM +0100, Luis R. Rodriguez wrote:
> On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote:
> > On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote:
> > > If you modify the target asm we currently do not force the
> > > recompilation of the firmware files. The target asm is in
> > > the firmware/Makefile, peg this file as a dependency to
> > > require re-compilation of firmware targets when the asm
> > > changes.
> > 
> > Why would changing the Makefile require the asm to change?
> 
> The Makefile is the file that provides the assembly logic, so
> changing the asm should affect recreating the binary.

Ah, I see it now, that's horrid, echoing asm from the Makefile itself :)

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1565037 — [PATCH v2] firmware/Makefile: force recompilation if makefile changes

If you modify the target asm we currently do not force the
recompilation of the firmware files. The target asm is in
the firmware/Makefile, peg this file as a dependency to
require re-compilation of firmware targets when the asm
changes.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---

Michal,

I had this patch as part of my linker table series [0] but have split it
off as its a small atomic separate change and can go in separately. Greg
prefers this be reviewed by the kbuild tree so sending it your way.
This v2 has no modifications, just resending it to the kbuild tree.

[0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org

 firmware/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/firmware/Makefile b/firmware/Makefile
index e297e1b52636..fa3e81c2a97b 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW   $@
 wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \
 		include/config/ppc32.h include/config/ppc64.h \
 		include/config/superh32.h include/config/superh64.h \
-		include/config/x86_32.h include/config/x86_64.h)
+		include/config/x86_32.h include/config/x86_64.h \
+		firmware/Makefile)
 
 $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps)
 	$(call cmd,fwbin,$(patsubst %.gen.S,%,$@))
-- 
2.11.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web