Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1565031

Re: [PATCH] firmware/Makefile: force recompilation if makefile changes

From "Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] firmware/Makefile: force recompilation if makefile changes
Date 2017-01-23 16:10 +0100
Message-ID <t2OpR-812-37@gated-at.bofh.it> (permalink)
References <t12ng-6Z8-11@gated-at.bofh.it> <t1i8F-jB-1@gated-at.bofh.it> <t2OpQ-812-25@gated-at.bofh.it> <t2OpR-812-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 23, 2017 at 9:02 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Jan 23, 2017 at 03:59:52PM +0100, Luis R. Rodriguez wrote:
>> On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote:
>> > On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote:
>> > > If you modify the target asm we currently do not force the
>> > > recompilation of the firmware files. The target asm is in
>> > > the firmware/Makefile, peg this file as a dependency to
>> > > require re-compilation of firmware targets when the asm
>> > > changes.
>> >
>> > Why would changing the Makefile require the asm to change?
>>
>> The Makefile is the file that provides the assembly logic, so
>> changing the asm should affect recreating the binary.
>
> Ah, I see it now, that's horrid, echoing asm from the Makefile itself :)

Yeah, I can change the way that works but I think I would much prefer
to make that a separate atomic functional change.

  Luis

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] firmware/Makefile: force recompilation if makefile changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-18 18:40 +0100
  Re: [PATCH] firmware/Makefile: force recompilation if makefile  changes Greg KH <gregkh@linuxfoundation.org> - 2017-01-19 11:30 +0100
    Re: [PATCH] firmware/Makefile: force recompilation if makefile  changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-23 16:10 +0100
      Re: [PATCH] firmware/Makefile: force recompilation if makefile changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-23 16:10 +0100
      Re: [PATCH] firmware/Makefile: force recompilation if makefile  changes Greg KH <gregkh@linuxfoundation.org> - 2017-01-23 16:10 +0100
  [PATCH v2] firmware/Makefile: force recompilation if makefile changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-23 16:10 +0100

csiph-web