Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1565035

Re: [PATCH] firmware/Makefile: force recompilation if makefile changes

Show all headers | View raw

On Mon, Jan 23, 2017 at 03:59:52PM +0100, Luis R. Rodriguez wrote:
> On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote:
> > On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote:
> > > If you modify the target asm we currently do not force the
> > > recompilation of the firmware files. The target asm is in
> > > the firmware/Makefile, peg this file as a dependency to
> > > require re-compilation of firmware targets when the asm
> > > changes.
> > 
> > Why would changing the Makefile require the asm to change?
> 
> The Makefile is the file that provides the assembly logic, so
> changing the asm should affect recreating the binary.

Ah, I see it now, that's horrid, echoing asm from the Makefile itself :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] firmware/Makefile: force recompilation if makefile changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-18 18:40 +0100
  Re: [PATCH] firmware/Makefile: force recompilation if makefile  changes Greg KH <gregkh@linuxfoundation.org> - 2017-01-19 11:30 +0100
    Re: [PATCH] firmware/Makefile: force recompilation if makefile  changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-23 16:10 +0100
      Re: [PATCH] firmware/Makefile: force recompilation if makefile changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-23 16:10 +0100
      Re: [PATCH] firmware/Makefile: force recompilation if makefile  changes Greg KH <gregkh@linuxfoundation.org> - 2017-01-23 16:10 +0100
  [PATCH v2] firmware/Makefile: force recompilation if makefile changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-23 16:10 +0100

csiph-web