Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473397 > unrolled thread

[PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
    [PATCH 5/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
    [PATCH 2/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
    [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
      Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 19:50 +0200
        Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 10:50 +0200
          Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 11:10 +0200
            Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 11:20 +0200
              Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 11:30 +0200
                Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 11:40 +0200
                  Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 11:50 +0200
      Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-08-31 20:00 +0200
        Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 10:40 +0200
    Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 15:00 +0200
      Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 15:50 +0200
        Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 19:50 +0200
        Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-08-31 20:00 +0200
          Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 10:40 +0200
            Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-09-01 12:10 +0200
              Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Mark Rutland <mark.rutland@arm.com> - 2016-09-01 13:50 +0200
                Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-09-01 14:10 +0200

Page 1 of 2  [1] 2  Next page →

#1473397 — [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

Hello Krzysztof,

This series removes the usage of the skeleton.dtsi in all the Exynos dts,
which allows to get rid of the DTC warnings about a mismatch between the
memory nodes' unit names and reg properties.

Patches are pretty trivial and shouldn't cause functional changes AFAIK,
but only the Exynos5 changes have been tested. The others patches were
just built tested.

Best regards,
Javier


Javier Martinez Canillas (7):
  ARM: dts: exynos: Add missing memory node for Exynos5440 boards
  ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3
  ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos4
  ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos5
  ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS
  ARM: dts: exynos: Add missing unit name to memory nodes in Exynos4 DTS
  ARM: dts: exynos: Add missing unit name to memory nodes in Exynos5 DTS

 arch/arm/boot/dts/exynos3250-artik5.dtsi           | 3 ++-
 arch/arm/boot/dts/exynos3250-monk.dts              | 3 ++-
 arch/arm/boot/dts/exynos3250-rinato.dts            | 3 ++-
 arch/arm/boot/dts/exynos3250.dtsi                  | 3 ++-
 arch/arm/boot/dts/exynos4.dtsi                     | 3 ++-
 arch/arm/boot/dts/exynos4210-origen.dts            | 3 ++-
 arch/arm/boot/dts/exynos4210-smdkv310.dts          | 3 ++-
 arch/arm/boot/dts/exynos4210-trats.dts             | 3 ++-
 arch/arm/boot/dts/exynos4210-universal_c210.dts    | 3 ++-
 arch/arm/boot/dts/exynos4412-odroidu3.dts          | 3 ++-
 arch/arm/boot/dts/exynos4412-odroidx.dts           | 3 ++-
 arch/arm/boot/dts/exynos4412-odroidx2.dts          | 3 ++-
 arch/arm/boot/dts/exynos4412-origen.dts            | 3 ++-
 arch/arm/boot/dts/exynos4412-smdk4412.dts          | 3 ++-
 arch/arm/boot/dts/exynos4412-tiny4412.dts          | 3 ++-
 arch/arm/boot/dts/exynos4412-trats2.dts            | 3 ++-
 arch/arm/boot/dts/exynos4415.dtsi                  | 3 ++-
 arch/arm/boot/dts/exynos5.dtsi                     | 3 ++-
 arch/arm/boot/dts/exynos5250-arndale.dts           | 3 ++-
 arch/arm/boot/dts/exynos5250-smdk5250.dts          | 3 ++-
 arch/arm/boot/dts/exynos5250-snow-common.dtsi      | 3 ++-
 arch/arm/boot/dts/exynos5250-spring.dts            | 3 ++-
 arch/arm/boot/dts/exynos5260-xyref5260.dts         | 3 ++-
 arch/arm/boot/dts/exynos5260.dtsi                  | 4 ++--
 arch/arm/boot/dts/exynos5410-odroidxu.dts          | 3 ++-
 arch/arm/boot/dts/exynos5410-smdk5410.dts          | 3 ++-
 arch/arm/boot/dts/exynos5420-arndale-octa.dts      | 3 ++-
 arch/arm/boot/dts/exynos5420-peach-pit.dts         | 3 ++-
 arch/arm/boot/dts/exynos5420-smdk5420.dts          | 3 ++-
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 3 ++-
 arch/arm/boot/dts/exynos5440-sd5v1.dts             | 5 +++++
 arch/arm/boot/dts/exynos5440-ssdk5440.dts          | 5 +++++
 arch/arm/boot/dts/exynos5440.dtsi                  | 3 ++-
 arch/arm/boot/dts/exynos54xx.dtsi                  | 1 -
 arch/arm/boot/dts/exynos5800-peach-pi.dts          | 3 ++-
 35 files changed, 74 insertions(+), 34 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1473400 — [PATCH 5/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS

This patch fixes the following DTC warnings:

"Node /memory has a reg or ranges property, but no unit name"

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +-
 arch/arm/boot/dts/exynos3250-monk.dts    | 2 +-
 arch/arm/boot/dts/exynos3250-rinato.dts  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
index bedc13bef5d9..a70819b1b739 100644
--- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
+++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
@@ -24,7 +24,7 @@
 		stdout-path = &serial_2;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x1ff00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 249fcfd5b297..66f04f6ba6bb 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -27,7 +27,7 @@
 		i2c7 = &i2c_max77836;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x1ff00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index ae125ece061d..3967ee5f7752 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -27,7 +27,7 @@
 		i2c7 = &i2c_max77836;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x1ff00000>;
 	};
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1473403 — [PATCH 2/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3

The skeleton.dtsi file was removed in ARM64 for different reasons as
explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").

These also applies to ARM and it will also allow to get rid of the
following DTC warnings in the future:

"Node /memory has a reg or ranges property, but no unit name"

The disassembled DTB are almost the same besides an empty chosen
node being removed and nodes reordered, so it should not have
functional changes.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/exynos3250-artik5.dtsi | 1 +
 arch/arm/boot/dts/exynos3250-monk.dts    | 1 +
 arch/arm/boot/dts/exynos3250-rinato.dts  | 1 +
 arch/arm/boot/dts/exynos3250.dtsi        | 3 ++-
 4 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
index 130e946f1414..bedc13bef5d9 100644
--- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
+++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
@@ -25,6 +25,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x1ff00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 8c8906266310..249fcfd5b297 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -28,6 +28,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg =  <0x40000000 0x1ff00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index a92181368e5b..ae125ece061d 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -28,6 +28,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg =  <0x40000000 0x1ff00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 70e3aceab3a9..e9d2556c0dfd 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -17,7 +17,6 @@
  * published by the Free Software Foundation.
  */
 
-#include "skeleton.dtsi"
 #include "exynos4-cpu-thermal.dtsi"
 #include "exynos-syscon-restart.dtsi"
 #include <dt-bindings/clock/exynos3250.h>
@@ -25,6 +24,8 @@
 / {
 	compatible = "samsung,exynos3250";
 	interrupt-parent = <&gic>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		pinctrl0 = &pinctrl_0;
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1473405 — [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

The skeleton.dtsi file was removed in ARM64 for different reasons as
explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").

These also applies to ARM and it will also allow to get rid of the
following DTC warnings in the future:

"Node /memory has a reg or ranges property, but no unit name"

But these boards don't have a memory node defined, so removing the
skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
compiled DTB. Add a dummy memory node so the compiled DTB doesn't
change if the skeleton.dtsi is removed from exynos4.dtsi.

Eventually the correct starting addresses and sizes should be used
but I didn't find that information.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
 arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
index a98501bab6fc..333db4ff373a 100644
--- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
+++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
@@ -20,6 +20,11 @@
 		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
 	};
 
+	memory {
+		device_type = "memory";
+		reg = <0 0>;
+	};
+
 	fixed-rate-clocks {
 		xtal {
 			compatible = "samsung,clock-xtal";
diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
index 6a0d802e87c8..82fea6f94704 100644
--- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
+++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
@@ -21,6 +21,11 @@
 		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
 	};
 
+	memory {
+		device_type = "memory";
+		reg = <0 0>;
+	};
+
 	fixed-rate-clocks {
 		xtal {
 			compatible = "samsung,clock-xtal";
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1473756 — Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

On Wed, Aug 31, 2016 at 02:14:33PM +0200, Javier Martinez Canillas wrote:
> The skeleton.dtsi file was removed in ARM64 for different reasons as
> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
> 
> These also applies to ARM and it will also allow to get rid of the
> following DTC warnings in the future:
> 
> "Node /memory has a reg or ranges property, but no unit name"
> 
> But these boards don't have a memory node defined, so removing the
> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
> change if the skeleton.dtsi is removed from exynos4.dtsi.

You mean extnos5440.dtsi?

> 
> Eventually the correct starting addresses and sizes should be used
> but I didn't find that information.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> index a98501bab6fc..333db4ff373a 100644
> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> @@ -20,6 +20,11 @@
>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>  	};
>  
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0>;
> +	};
> +
>  	fixed-rate-clocks {
>  		xtal {
>  			compatible = "samsung,clock-xtal";
> diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> index 6a0d802e87c8..82fea6f94704 100644
> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> @@ -21,6 +21,11 @@
>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>  	};
>  
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0>;
> +	};

This looks okay, but the default size and address cells won't be
present. Won't that be a problem?

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1474178 — Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

Hello Krzysztof,

On 08/31/2016 07:46 PM, Krzysztof Kozlowski wrote:
> On Wed, Aug 31, 2016 at 02:14:33PM +0200, Javier Martinez Canillas wrote:
>> The skeleton.dtsi file was removed in ARM64 for different reasons as
>> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
>>
>> These also applies to ARM and it will also allow to get rid of the
>> following DTC warnings in the future:
>>
>> "Node /memory has a reg or ranges property, but no unit name"
>>
>> But these boards don't have a memory node defined, so removing the
>> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
>> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
>> change if the skeleton.dtsi is removed from exynos4.dtsi.
> 
> You mean extnos5440.dtsi?
>

Yes, I meant exynos5440.dtsi, it's a commit message copy and paste error.
Thanks for pointing out, I'll fix it in v2.
 
>>
>> Eventually the correct starting addresses and sizes should be used
>> but I didn't find that information.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> index a98501bab6fc..333db4ff373a 100644
>> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> @@ -20,6 +20,11 @@
>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>  	};
>>  
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0 0>;
>> +	};
>> +
>>  	fixed-rate-clocks {
>>  		xtal {
>>  			compatible = "samsung,clock-xtal";
>> diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>> index 6a0d802e87c8..82fea6f94704 100644
>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>> @@ -21,6 +21,11 @@
>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>  	};
>>  
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0 0>;
>> +	};
> 
> This looks okay, but the default size and address cells won't be
> present. Won't that be a problem?
>

They will be present since at this point exynos5440.dtsi is still including
exynos5440.dtsi, we are just overriding the memory node with the same values
than skeleton.dtsi so this can be removed later in patch 7/7.
 
> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1474196 — Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>> @@ -21,6 +21,11 @@
>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>  	};
>>>  
>>> +	memory {
>>> +		device_type = "memory";
>>> +		reg = <0 0>;
>>> +	};
>>
>> This looks okay, but the default size and address cells won't be
>> present. Won't that be a problem?
>>
> 
> They will be present since at this point exynos5440.dtsi is still including
> exynos5440.dtsi, we are just overriding the memory node with the same values
> than skeleton.dtsi so this can be removed later in patch 7/7.

I don't get it. exynos5440.dtsi does not set size/address cells in top node.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1474203 — Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

Hello Krzysztof,

On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>> @@ -21,6 +21,11 @@
>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>  	};
>>>>  
>>>> +	memory {
>>>> +		device_type = "memory";
>>>> +		reg = <0 0>;
>>>> +	};
>>>
>>> This looks okay, but the default size and address cells won't be
>>> present. Won't that be a problem?
>>>
>>
>> They will be present since at this point exynos5440.dtsi is still including
>> exynos5440.dtsi, we are just overriding the memory node with the same values
>> than skeleton.dtsi so this can be removed later in patch 7/7.
> 
> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>

Sorry, maybe I'm misunderstanding your question. The size/address cells are set
in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
set in that included dtsi).

IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
before and after $SUBJECT.

> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1474208 — Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>> @@ -21,6 +21,11 @@
>>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>>  	};
>>>>>  
>>>>> +	memory {
>>>>> +		device_type = "memory";
>>>>> +		reg = <0 0>;
>>>>> +	};
>>>>
>>>> This looks okay, but the default size and address cells won't be
>>>> present. Won't that be a problem?
>>>>
>>>
>>> They will be present since at this point exynos5440.dtsi is still including
>>> exynos5440.dtsi, we are just overriding the memory node with the same values
>>> than skeleton.dtsi so this can be removed later in patch 7/7.
>>
>> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>>
> 
> Sorry, maybe I'm misunderstanding your question. The size/address cells are set
> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
> set in that included dtsi).

Where? Nothing in my sources...

15 / {
16         compatible = "samsung,exynos5440", "samsung,exynos5";
17
18         interrupt-parent = <&gic>;

> 
> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
> before and after $SUBJECT.

Maybe these are also the default values so no differences... stating
them explicitly would be useful.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1474224 — Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

Hello Krzysztof,

On 09/01/2016 11:28 AM, Krzysztof Kozlowski wrote:
> On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
>>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>> @@ -21,6 +21,11 @@
>>>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>>>  	};
>>>>>>  
>>>>>> +	memory {
>>>>>> +		device_type = "memory";
>>>>>> +		reg = <0 0>;
>>>>>> +	};
>>>>>
>>>>> This looks okay, but the default size and address cells won't be
>>>>> present. Won't that be a problem?
>>>>>
>>>>
>>>> They will be present since at this point exynos5440.dtsi is still including
>>>> exynos5440.dtsi, we are just overriding the memory node with the same values
>>>> than skeleton.dtsi so this can be removed later in patch 7/7.
>>>
>>> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>>>
>>
>> Sorry, maybe I'm misunderstanding your question. The size/address cells are set
>> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
>> set in that included dtsi).
> 
> Where? Nothing in my sources...
> 
> 15 / {
> 16         compatible = "samsung,exynos5440", "samsung,exynos5";
> 17
> 18         interrupt-parent = <&gic>;
>

No, I meant that these are set by the fact that exynos5440.dtsi is including
the skeleton.dtsi, since the dtsi set these properties in the top node.

>>
>> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
>> before and after $SUBJECT.
> 
> Maybe these are also the default values so no differences... stating
> them explicitly would be useful.
>

I could do it in this patch... but I don't see why that should be needed since:

a) All the others Exynos SoC dtsi file don't explicitly set these properties
   since are set by skeleton.dtsi when including it. So not adding them keeps
   exynos5440.dtsi consistent with the other SoC dtsi.

b) Adding those to the Exynos SoC dtsi when removing the skeleton.dtsi is done
   in a later patch of this series. Again, making it consistent with all the
   Exynos SoC dtsi since none will include skeleton.dtsi anymore.

> Best regards,
> Krzysztof
> 
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1474234 — Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

On 09/01/2016 11:36 AM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 09/01/2016 11:28 AM, Krzysztof Kozlowski wrote:
>> On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote:
>>> Hello Krzysztof,
>>>
>>> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
>>>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>>> @@ -21,6 +21,11 @@
>>>>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>>>>  	};
>>>>>>>  
>>>>>>> +	memory {
>>>>>>> +		device_type = "memory";
>>>>>>> +		reg = <0 0>;
>>>>>>> +	};
>>>>>>
>>>>>> This looks okay, but the default size and address cells won't be
>>>>>> present. Won't that be a problem?
>>>>>>
>>>>>
>>>>> They will be present since at this point exynos5440.dtsi is still including
>>>>> exynos5440.dtsi, we are just overriding the memory node with the same values
>>>>> than skeleton.dtsi so this can be removed later in patch 7/7.
>>>>
>>>> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>>>>
>>>
>>> Sorry, maybe I'm misunderstanding your question. The size/address cells are set
>>> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
>>> set in that included dtsi).
>>
>> Where? Nothing in my sources...
>>
>> 15 / {
>> 16         compatible = "samsung,exynos5440", "samsung,exynos5";
>> 17
>> 18         interrupt-parent = <&gic>;
>>
> 
> No, I meant that these are set by the fact that exynos5440.dtsi is including
> the skeleton.dtsi, since the dtsi set these properties in the top node.
> 
>>>
>>> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
>>> before and after $SUBJECT.
>>
>> Maybe these are also the default values so no differences... stating
>> them explicitly would be useful.
>>
> 
> I could do it in this patch... but I don't see why that should be needed since:
> 
> a) All the others Exynos SoC dtsi file don't explicitly set these properties
>    since are set by skeleton.dtsi when including it. So not adding them keeps
>    exynos5440.dtsi consistent with the other SoC dtsi.
> 
> b) Adding those to the Exynos SoC dtsi when removing the skeleton.dtsi is done
>    in a later patch of this series. Again, making it consistent with all the
>    Exynos SoC dtsi since none will include skeleton.dtsi anymore.

Ah, I missed it. The 'b' is the solution I wanted so everything is fine.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1473761 — Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

Hi,

On Wednesday, August 31, 2016 02:14:33 PM Javier Martinez Canillas wrote:
> The skeleton.dtsi file was removed in ARM64 for different reasons as
> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
> 
> These also applies to ARM and it will also allow to get rid of the
> following DTC warnings in the future:
> 
> "Node /memory has a reg or ranges property, but no unit name"
> 
> But these boards don't have a memory node defined, so removing the
> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
> change if the skeleton.dtsi is removed from exynos4.dtsi.
> 
> Eventually the correct starting addresses and sizes should be used
> but I didn't find that information.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> index a98501bab6fc..333db4ff373a 100644
> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> @@ -20,6 +20,11 @@
>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>  	};
>  
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0>;
> +	};

I think that this node deserves a FIXME comment.

> +
>  	fixed-rate-clocks {
>  		xtal {
>  			compatible = "samsung,clock-xtal";
> diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> index 6a0d802e87c8..82fea6f94704 100644
> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> @@ -21,6 +21,11 @@
>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>  	};
>  
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0>;
> +	};

ditto

>  	fixed-rate-clocks {
>  		xtal {
>  			compatible = "samsung,clock-xtal";
> 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[toc] | [prev] | [next] | [standalone]

#1474168 — Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

Hello Bartlomiej,

On 08/31/2016 07:22 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, August 31, 2016 02:14:33 PM Javier Martinez Canillas wrote:
>> The skeleton.dtsi file was removed in ARM64 for different reasons as
>> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
>>
>> These also applies to ARM and it will also allow to get rid of the
>> following DTC warnings in the future:
>>
>> "Node /memory has a reg or ranges property, but no unit name"
>>
>> But these boards don't have a memory node defined, so removing the
>> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
>> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
>> change if the skeleton.dtsi is removed from exynos4.dtsi.
>>
>> Eventually the correct starting addresses and sizes should be used
>> but I didn't find that information.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> index a98501bab6fc..333db4ff373a 100644
>> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> @@ -20,6 +20,11 @@
>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>  	};
>>  
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0 0>;
>> +	};
> 
> I think that this node deserves a FIXME comment.
> 

Agreed. I'll add one in v2 for both nodes.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1473433 — Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> which allows to get rid of the DTC warnings about a mismatch between the
> memory nodes' unit names and reg properties.
> 
> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> but only the Exynos5 changes have been tested. The others patches were
> just built tested.

I think this is a common problem, not only Exynos-specific, so I would
prefer to stick to common pattern. Either all DTS/DTSI include skeleton
or none of them.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1473485 — Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

Hello Krzysztof,

On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
>> which allows to get rid of the DTC warnings about a mismatch between the
>> memory nodes' unit names and reg properties.
>>
>> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
>> but only the Exynos5 changes have been tested. The others patches were
>> just built tested.
> 
> I think this is a common problem, not only Exynos-specific, so I would

That's correct.

> prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> or none of them.
>

The idea is to get rid of skeleton.dtsi [0], but that will of course take
time until the dtsi is removed from all the files. So this patch is a step
in the right direction so at least Exynos is not a blocker to remove it.
 
> Best regards,
> Krzysztof
> 

[0]: https://lkml.org/lkml/2016/8/3/195

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1473749 — Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

On Wed, Aug 31, 2016 at 03:45:24PM +0200, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >> which allows to get rid of the DTC warnings about a mismatch between the
> >> memory nodes' unit names and reg properties.
> >>
> >> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >> but only the Exynos5 changes have been tested. The others patches were
> >> just built tested.
> > 
> > I think this is a common problem, not only Exynos-specific, so I would
> 
> That's correct.
> 
> > prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> > or none of them.
> >
> 
> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> time until the dtsi is removed from all the files. So this patch is a step
> in the right direction so at least Exynos is not a blocker to remove it.

Acknowledged, thanks for pointing it.

I will start review and apply.

BR,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1473765 — Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

Hi,

On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >> which allows to get rid of the DTC warnings about a mismatch between the
> >> memory nodes' unit names and reg properties.
> >>
> >> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >> but only the Exynos5 changes have been tested. The others patches were
> >> just built tested.
> > 
> > I think this is a common problem, not only Exynos-specific, so I would
> 
> That's correct.
> 
> > prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> > or none of them.
> >
> 
> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> time until the dtsi is removed from all the files. So this patch is a step
> in the right direction so at least Exynos is not a blocker to remove it.

Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
then it is okay to apply Exynos specific changes, otherwise the code
should stay as it is currently.

Exynos won't be a blocker since we have your patches now and they can
be applied when/if needed ;)..

> > Best regards,
> > Krzysztof
> > 
> 
> [0]: https://lkml.org/lkml/2016/8/3/195
> 
> Best regards,

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[toc] | [prev] | [next] | [standalone]

#1474171 — Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

Hello Bartlomiej,

On 08/31/2016 07:40 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
>>> On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
>>>> Hello Krzysztof,
>>>>
>>>> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
>>>> which allows to get rid of the DTC warnings about a mismatch between the
>>>> memory nodes' unit names and reg properties.
>>>>
>>>> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
>>>> but only the Exynos5 changes have been tested. The others patches were
>>>> just built tested.
>>>
>>> I think this is a common problem, not only Exynos-specific, so I would
>>
>> That's correct.
>>
>>> prefer to stick to common pattern. Either all DTS/DTSI include skeleton
>>> or none of them.
>>>
>>
>> The idea is to get rid of skeleton.dtsi [0], but that will of course take
>> time until the dtsi is removed from all the files. So this patch is a step
>> in the right direction so at least Exynos is not a blocker to remove it.
> 
> Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
> then it is okay to apply Exynos specific changes, otherwise the code
> should stay as it is currently.
> 
> Exynos won't be a blocker since we have your patches now and they can
> be applied when/if needed ;)..
>

Sorry but I disagree. I see no reasons to need this to be an atomic, rather
than incremental change. Deprecated things are usually handled by removing
the usage and once there are no users, finally removing them.

Also, each subsystem maintainer should carry the patches for their platform
so it can't be a kernel wide change anyways and most likely split by kernel
releases.
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1474248 — Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

Hi,

On Thursday, September 01, 2016 10:35:15 AM Javier Martinez Canillas wrote:
> Hello Bartlomiej,
> 
> On 08/31/2016 07:40 PM, Bartlomiej Zolnierkiewicz wrote:
> > 
> > Hi,
> > 
> > On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> >>> On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >>>> Hello Krzysztof,
> >>>>
> >>>> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >>>> which allows to get rid of the DTC warnings about a mismatch between the
> >>>> memory nodes' unit names and reg properties.
> >>>>
> >>>> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >>>> but only the Exynos5 changes have been tested. The others patches were
> >>>> just built tested.
> >>>
> >>> I think this is a common problem, not only Exynos-specific, so I would
> >>
> >> That's correct.
> >>
> >>> prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> >>> or none of them.
> >>>
> >>
> >> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> >> time until the dtsi is removed from all the files. So this patch is a step
> >> in the right direction so at least Exynos is not a blocker to remove it.
> > 
> > Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
> > then it is okay to apply Exynos specific changes, otherwise the code
> > should stay as it is currently.
> > 
> > Exynos won't be a blocker since we have your patches now and they can
> > be applied when/if needed ;)..
> >
> 
> Sorry but I disagree. I see no reasons to need this to be an atomic, rather
> than incremental change. Deprecated things are usually handled by removing
> the usage and once there are no users, finally removing them.

Yes, given that there is agreement on the direction and people are aware
of the needed changes.  This doesn't seem to be a case yet as there is
no comment in skeleton.dtsi about being deprecated and other platforms'
Maintainers are not aware of the need for the change.

> Also, each subsystem maintainer should carry the patches for their platform
> so it can't be a kernel wide change anyways and most likely split by kernel
> releases.

Yep.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[toc] | [prev] | [next] | [standalone]

#1474347 — Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

On Thu, Sep 01, 2016 at 11:59:48AM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Thursday, September 01, 2016 10:35:15 AM Javier Martinez Canillas wrote:
> > On 08/31/2016 07:40 PM, Bartlomiej Zolnierkiewicz wrote:
> > > On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> > >> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> > >> time until the dtsi is removed from all the files. So this patch is a step
> > >> in the right direction so at least Exynos is not a blocker to remove it.
> > > 
> > > Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
> > > then it is okay to apply Exynos specific changes, otherwise the code
> > > should stay as it is currently.
> > > 
> > > Exynos won't be a blocker since we have your patches now and they can
> > > be applied when/if needed ;)..
> > 
> > Sorry but I disagree. I see no reasons to need this to be an atomic, rather
> > than incremental change. Deprecated things are usually handled by removing
> > the usage and once there are no users, finally removing them.
> 
> Yes, given that there is agreement on the direction and people are aware
> of the needed changes.  This doesn't seem to be a case yet as there is
> no comment in skeleton.dtsi about being deprecated and other platforms'
> Maintainers are not aware of the need for the change.

On the DT side we're all agreed that skeleton.dtsi should die. I'll send
a patch adding a note to skeleton.dtsi to make this more obvious, but
that shouldn't be a blocker for removing existing uses.

Thanks,
Mark.

[toc] | [prev] | [next] | [standalone]

Page 1 of 2  [1] 2  Next page →

Back to top | Article view | linux.kernel

csiph-web