Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1474208
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards |
| Date | 2016-09-01 11:30 +0200 |
| Message-ID | <scwtP-81r-11@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <sccEO-2iO-51@gated-at.bofh.it> <schOa-5mI-45@gated-at.bofh.it> <scvR8-7fO-13@gated-at.bofh.it> <scwau-7KC-37@gated-at.bofh.it> <scwk9-7Sa-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>> @@ -21,6 +21,11 @@
>>>>> bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>> };
>>>>>
>>>>> + memory {
>>>>> + device_type = "memory";
>>>>> + reg = <0 0>;
>>>>> + };
>>>>
>>>> This looks okay, but the default size and address cells won't be
>>>> present. Won't that be a problem?
>>>>
>>>
>>> They will be present since at this point exynos5440.dtsi is still including
>>> exynos5440.dtsi, we are just overriding the memory node with the same values
>>> than skeleton.dtsi so this can be removed later in patch 7/7.
>>
>> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>>
>
> Sorry, maybe I'm misunderstanding your question. The size/address cells are set
> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
> set in that included dtsi).
Where? Nothing in my sources...
15 / {
16 compatible = "samsung,exynos5440", "samsung,exynos5";
17
18 interrupt-parent = <&gic>;
>
> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
> before and after $SUBJECT.
Maybe these are also the default values so no differences... stating
them explicitly would be useful.
Best regards,
Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
[PATCH 5/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
[PATCH 2/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
[PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 19:50 +0200
Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 10:50 +0200
Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 11:10 +0200
Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 11:20 +0200
Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 11:30 +0200
Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 11:40 +0200
Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 11:50 +0200
Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-08-31 20:00 +0200
Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 10:40 +0200
Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 15:00 +0200
Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 15:50 +0200
Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 19:50 +0200
Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-08-31 20:00 +0200
Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 10:40 +0200
Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-09-01 12:10 +0200
Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Mark Rutland <mark.rutland@arm.com> - 2016-09-01 13:50 +0200
Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-09-01 14:10 +0200
csiph-web