Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473765

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

Show all headers | View raw

Hi,

On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >> which allows to get rid of the DTC warnings about a mismatch between the
> >> memory nodes' unit names and reg properties.
> >>
> >> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >> but only the Exynos5 changes have been tested. The others patches were
> >> just built tested.
> > 
> > I think this is a common problem, not only Exynos-specific, so I would
> 
> That's correct.
> 
> > prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> > or none of them.
> >
> 
> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> time until the dtsi is removed from all the files. So this patch is a step
> in the right direction so at least Exynos is not a blocker to remove it.

Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
then it is okay to apply Exynos specific changes, otherwise the code
should stay as it is currently.

Exynos won't be a blocker since we have your patches now and they can
be applied when/if needed ;)..

> > Best regards,
> > Krzysztof
> > 
> 
> [0]: https://lkml.org/lkml/2016/8/3/195
> 
> Best regards,

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 5/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 2/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:20 +0200
    Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 19:50 +0200
      Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 10:50 +0200
        Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 11:10 +0200
          Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 11:20 +0200
            Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 11:30 +0200
              Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 11:40 +0200
                Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 11:50 +0200
    Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-08-31 20:00 +0200
      Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for  Exynos5440 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 10:40 +0200
  Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 15:00 +0200
    Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 15:50 +0200
      Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 19:50 +0200
      Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-08-31 20:00 +0200
        Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-01 10:40 +0200
          Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-09-01 12:10 +0200
            Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Mark Rutland <mark.rutland@arm.com> - 2016-09-01 13:50 +0200
              Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix  memory node DTC warnings Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-09-01 14:10 +0200

csiph-web