Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533843 > unrolled thread
| Started by | Pan Bian <bianpan2016@163.com> |
|---|---|
| First post | 2016-12-01 07:30 +0100 |
| Last post | 2016-12-08 01:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] clk: clk-wm831x: fix a logic error Pan Bian <bianpan2016@163.com> - 2016-12-01 07:30 +0100
Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-12-01 10:40 +0100
Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error Stephen Boyd <sboyd@codeaurora.org> - 2016-12-08 01:30 +0100
| From | Pan Bian <bianpan2016@163.com> |
|---|---|
| Date | 2016-12-01 07:30 +0100 |
| Subject | [PATCH 1/1] clk: clk-wm831x: fix a logic error |
| Message-ID | <sJt2x-aP-1@gated-at.bofh.it> |
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
wm831x_clkout_is_prepared() returns "true" when it fails to read
CLOCK_CONTROL_1. "true" means the device is already prepared. So
return "true" on the read failure seems improper.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/clk/clk-wm831x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-wm831x.c b/drivers/clk/clk-wm831x.c
index f4fdac5..0621fbf 100644
--- a/drivers/clk/clk-wm831x.c
+++ b/drivers/clk/clk-wm831x.c
@@ -243,7 +243,7 @@ static int wm831x_clkout_is_prepared(struct clk_hw *hw)
if (ret < 0) {
dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n",
ret);
- return true;
+ return false;
}
return (ret & WM831X_CLKOUT_ENA) != 0;
--
1.9.1
[toc] | [next] | [standalone]
| From | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| Date | 2016-12-01 10:40 +0100 |
| Message-ID | <sJw0q-23K-23@gated-at.bofh.it> |
| In reply to | #1533843 |
On Thu, Dec 01, 2016 at 02:25:44PM +0800, Pan Bian wrote: > Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function > wm831x_clkout_is_prepared() returns "true" when it fails to read > CLOCK_CONTROL_1. "true" means the device is already prepared. So > return "true" on the read failure seems improper. > > Signed-off-by: Pan Bian <bianpan2016@163.com> > --- Looks good to me: Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
[toc] | [prev] | [next] | [standalone]
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2016-12-08 01:30 +0100 |
| Message-ID | <sLUL0-7jL-25@gated-at.bofh.it> |
| In reply to | #1533843 |
On 12/01, Pan Bian wrote: > Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function > wm831x_clkout_is_prepared() returns "true" when it fails to read > CLOCK_CONTROL_1. "true" means the device is already prepared. So > return "true" on the read failure seems improper. > > Signed-off-by: Pan Bian <bianpan2016@163.com> > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web