Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533927
| From | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error |
| Date | 2016-12-01 10:40 +0100 |
| Message-ID | <sJw0q-23K-23@gated-at.bofh.it> (permalink) |
| References | <sJt2x-aP-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Dec 01, 2016 at 02:25:44PM +0800, Pan Bian wrote: > Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function > wm831x_clkout_is_prepared() returns "true" when it fails to read > CLOCK_CONTROL_1. "true" means the device is already prepared. So > return "true" on the read failure seems improper. > > Signed-off-by: Pan Bian <bianpan2016@163.com> > --- Looks good to me: Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/1] clk: clk-wm831x: fix a logic error Pan Bian <bianpan2016@163.com> - 2016-12-01 07:30 +0100 Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-12-01 10:40 +0100 Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error Stephen Boyd <sboyd@codeaurora.org> - 2016-12-08 01:30 +0100
csiph-web