[PATCH 1/1] clk: clk-wm831x: fix a logic error

From	Pan Bian <bianpan2016@163.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] clk: clk-wm831x: fix a logic error
Date	2016-12-01 07:30 +0100
Message-ID	<sJt2x-aP-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
wm831x_clkout_is_prepared() returns "true" when it fails to read
CLOCK_CONTROL_1. "true" means the device is already prepared. So
return "true" on the read failure seems improper.

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 drivers/clk/clk-wm831x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-wm831x.c b/drivers/clk/clk-wm831x.c
index f4fdac5..0621fbf 100644
--- a/drivers/clk/clk-wm831x.c
+++ b/drivers/clk/clk-wm831x.c
@@ -243,7 +243,7 @@ static int wm831x_clkout_is_prepared(struct clk_hw *hw)
 	if (ret < 0) {
 		dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n",
 			ret);
-		return true;
+		return false;
 	}
 
 	return (ret & WM831X_CLKOUT_ENA) != 0;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] clk: clk-wm831x: fix a logic error Pan Bian <bianpan2016@163.com> - 2016-12-01 07:30 +0100
  Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-12-01 10:40 +0100
  Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error Stephen Boyd <sboyd@codeaurora.org> - 2016-12-08 01:30 +0100

csiph-web