Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1531053 > unrolled thread
| Started by | Baolin Wang <baolin.wang@linaro.org> |
|---|---|
| First post | 2016-11-28 07:30 +0100 |
| Last post | 2016-11-29 03:30 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-28 07:30 +0100
Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Greg KH <gregkh@linuxfoundation.org> - 2016-11-28 08:30 +0100
Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-28 08:50 +0100
Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-11-28 16:20 +0100
Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-29 03:30 +0100
| From | Baolin Wang <baolin.wang@linaro.org> |
|---|---|
| Date | 2016-11-28 07:30 +0100 |
| Subject | Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement |
| Message-ID | <sInBT-6Us-1@gated-at.bofh.it> |
Hi Mathias, On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@linaro.org> wrote: > Since these 'return' statements are not generally useful in void > function, remove them. Also remove one unuseful 'break' statement > in xhci_setup_addressable_virt_dev() function. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > --- > Changes since v1: > - Add description of removing 'break' statement in commitlog. > --- Could you apply this patch if there are no other comments? Thanks. -- Baolin.wang Best Regards
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-11-28 08:30 +0100 |
| Subject | Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement |
| Message-ID | <sIoxY-7ud-15@gated-at.bofh.it> |
| In reply to | #1531053 |
On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote: > Hi Mathias, > > On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@linaro.org> wrote: > > Since these 'return' statements are not generally useful in void > > function, remove them. Also remove one unuseful 'break' statement > > in xhci_setup_addressable_virt_dev() function. > > > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > > --- > > Changes since v1: > > - Add description of removing 'break' statement in commitlog. > > --- > > Could you apply this patch if there are no other comments? Thanks. Less than a week response for a simple cleanup patch? Why the rush and pressure? Relax, this really isn't an important patch... greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Baolin Wang <baolin.wang@linaro.org> |
|---|---|
| Date | 2016-11-28 08:50 +0100 |
| Message-ID | <sIoRj-7B7-15@gated-at.bofh.it> |
| In reply to | #1531080 |
On 28 November 2016 at 15:21, Greg KH <gregkh@linuxfoundation.org> wrote: > On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote: >> Hi Mathias, >> >> On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@linaro.org> wrote: >> > Since these 'return' statements are not generally useful in void >> > function, remove them. Also remove one unuseful 'break' statement >> > in xhci_setup_addressable_virt_dev() function. >> > >> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> >> > --- >> > Changes since v1: >> > - Add description of removing 'break' statement in commitlog. >> > --- >> >> Could you apply this patch if there are no other comments? Thanks. > > Less than a week response for a simple cleanup patch? Why the rush and > pressure? Relax, this really isn't an important patch... I am sorry for the pressure, I just thought it is one simple cleanup patch. It is okay for me to wait for. -- Baolin.wang Best Regards
[toc] | [prev] | [next] | [standalone]
| From | Mathias Nyman <mathias.nyman@linux.intel.com> |
|---|---|
| Date | 2016-11-28 16:20 +0100 |
| Subject | Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement |
| Message-ID | <sIvSO-3L8-7@gated-at.bofh.it> |
| In reply to | #1531089 |
On 28.11.2016 09:41, Baolin Wang wrote: > On 28 November 2016 at 15:21, Greg KH <gregkh@linuxfoundation.org> wrote: >> On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote: >>> Hi Mathias, >>> >>> On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@linaro.org> wrote: >>>> Since these 'return' statements are not generally useful in void >>>> function, remove them. Also remove one unuseful 'break' statement >>>> in xhci_setup_addressable_virt_dev() function. >>>> >>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> >>>> --- >>>> Changes since v1: >>>> - Add description of removing 'break' statement in commitlog. >>>> --- >>> >>> Could you apply this patch if there are no other comments? Thanks. >> >> Less than a week response for a simple cleanup patch? Why the rush and >> pressure? Relax, this really isn't an important patch... > > I am sorry for the pressure, I just thought it is one simple cleanup > patch. It is okay for me to wait for. > Looks ok. If it applies I'll send it forward to usb-next after 4.10-rc1, It should end up in 4.11 -Mathias
[toc] | [prev] | [next] | [standalone]
| From | Baolin Wang <baolin.wang@linaro.org> |
|---|---|
| Date | 2016-11-29 03:30 +0100 |
| Message-ID | <sIGlb-293-3@gated-at.bofh.it> |
| In reply to | #1531384 |
On 28 November 2016 at 23:14, Mathias Nyman <mathias.nyman@linux.intel.com> wrote: > On 28.11.2016 09:41, Baolin Wang wrote: >> >> On 28 November 2016 at 15:21, Greg KH <gregkh@linuxfoundation.org> wrote: >>> >>> On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote: >>>> >>>> Hi Mathias, >>>> >>>> On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@linaro.org> >>>> wrote: >>>>> >>>>> Since these 'return' statements are not generally useful in void >>>>> function, remove them. Also remove one unuseful 'break' statement >>>>> in xhci_setup_addressable_virt_dev() function. >>>>> >>>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> >>>>> --- >>>>> Changes since v1: >>>>> - Add description of removing 'break' statement in commitlog. >>>>> --- >>>> >>>> >>>> Could you apply this patch if there are no other comments? Thanks. >>> >>> >>> Less than a week response for a simple cleanup patch? Why the rush and >>> pressure? Relax, this really isn't an important patch... >> >> >> I am sorry for the pressure, I just thought it is one simple cleanup >> patch. It is okay for me to wait for. >> > > Looks ok. > > If it applies I'll send it forward to usb-next after 4.10-rc1, > It should end up in 4.11 Thanks. -- Baolin.wang Best Regards
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web