Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement

From	Baolin Wang <baolin.wang@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement
Date	2016-11-29 03:30 +0100
Message-ID	<sIGlb-293-3@gated-at.bofh.it> (permalink)
References	<sH0o2-1XY-33@gated-at.bofh.it> <sInBT-6Us-1@gated-at.bofh.it> <sIoxY-7ud-15@gated-at.bofh.it> <sIoRj-7B7-15@gated-at.bofh.it> <sIvSO-3L8-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28 November 2016 at 23:14, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
> On 28.11.2016 09:41, Baolin Wang wrote:
>>
>> On 28 November 2016 at 15:21, Greg KH <gregkh@linuxfoundation.org> wrote:
>>>
>>> On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote:
>>>>
>>>> Hi Mathias,
>>>>
>>>> On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@linaro.org>
>>>> wrote:
>>>>>
>>>>> Since these 'return' statements are not generally useful in void
>>>>> function, remove them. Also remove one unuseful 'break' statement
>>>>> in xhci_setup_addressable_virt_dev() function.
>>>>>
>>>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>>>>> ---
>>>>> Changes since v1:
>>>>>   - Add description of removing 'break' statement in commitlog.
>>>>> ---
>>>>
>>>>
>>>> Could you apply this patch if there are no other comments? Thanks.
>>>
>>>
>>> Less than a week response for a simple cleanup patch?  Why the rush and
>>> pressure?  Relax, this really isn't an important patch...
>>
>>
>> I am sorry for the pressure, I just thought it is one simple cleanup
>> patch. It is okay for me to wait for.
>>
>
> Looks ok.
>
> If it applies I'll send it forward to usb-next after 4.10-rc1,
> It should end up in 4.11

Thanks.

-- 
Baolin.wang
Best Regards

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-28 07:30 +0100
  Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break'  statement Greg KH <gregkh@linuxfoundation.org> - 2016-11-28 08:30 +0100
    Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-28 08:50 +0100
      Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break'  statement Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-11-28 16:20 +0100
        Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-29 03:30 +0100

csiph-web