Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531080

Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement

Show all headers | View raw

On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote:
> Hi Mathias,
> 
> On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@linaro.org> wrote:
> > Since these 'return' statements are not generally useful in void
> > function, remove them. Also remove one unuseful 'break' statement
> > in xhci_setup_addressable_virt_dev() function.
> >
> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> > ---
> > Changes since v1:
> >  - Add description of removing 'break' statement in commitlog.
> > ---
> 
> Could you apply this patch if there are no other comments? Thanks.

Less than a week response for a simple cleanup patch?  Why the rush and
pressure?  Relax, this really isn't an important patch...

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-28 07:30 +0100
  Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break'  statement Greg KH <gregkh@linuxfoundation.org> - 2016-11-28 08:30 +0100
    Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-28 08:50 +0100
      Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break'  statement Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-11-28 16:20 +0100
        Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-29 03:30 +0100

csiph-web