Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462694 > unrolled thread

[PATCH] pinctrl: exynos: remove duplicate calls in irq handler

Back to article view | Back to linux.kernel

Contents

  [PATCH] pinctrl: exynos: remove duplicate calls in irq handler perr <strongbox8@zoho.com> - 2016-08-15 12:20 +0200
    Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Tomasz Figa <tomasz.figa@gmail.com> - 2016-08-15 13:40 +0200
    Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-15 19:00 +0200
      Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler perr perr <strongbox8@zoho.com> - 2016-08-16 02:00 +0200
        Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-16 08:10 +0200

#1462694 — [PATCH] pinctrl: exynos: remove duplicate calls in irq handler

Because chained_irq_enter() has already called chip->irq_mask() and
chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
so it's not necessary to call chip->irq_*() here.

Signed-off-by: perr <strongbox8@zoho.com>

---
 drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index 051b5bf..d32fa2b 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc)
 	int eint_irq;
 
 	chained_irq_enter(chip, desc);
-	chip->irq_mask(&desc->irq_data);
-
-	if (chip->irq_ack)
-		chip->irq_ack(&desc->irq_data);
 
 	eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq);
 	generic_handle_irq(eint_irq);
-	chip->irq_unmask(&desc->irq_data);
+
 	chained_irq_exit(chip, desc);
 }
 
-- 
1.9.3

[toc] | [next] | [standalone]

#1462719

Hi,

2016-08-15 19:17 GMT+09:00 perr <strongbox8@zoho.com>:
> Because chained_irq_enter() has already called chip->irq_mask() and
> chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
> so it's not necessary to call chip->irq_*() here.
>
> Signed-off-by: perr <strongbox8@zoho.com>
>
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>

Indeed, nice finding. Thanks!

Acked-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz

[toc] | [prev] | [next] | [standalone]

#1462992

On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote:
> Because chained_irq_enter() has already called chip->irq_mask() and
> chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
> so it's not necessary to call chip->irq_*() here.
> 
> Signed-off-by: perr <strongbox8@zoho.com>
> 
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>


Looks correct so for the patch itself:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

However, your name "Perr" confuses me a little bit. For the
Signed-off-by statement, as mentioned in
Documentation/SubmittingPatches, a real name is required. The name
should match the author.

Would you be so kind as to use a full, real name? Unless Perr is your
full, real name... then sorry for the trouble.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1463286

Sent using Zoho Mail


 ---- On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote ---- 
 > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: 
 > > Because chained_irq_enter() has already called chip->irq_mask() and 
 > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), 
 > > so it's not necessary to call chip->irq_*() here. 
 > >  
 > > Signed-off-by: perr <strongbox8@zoho.com> 
 > >  
 > > --- 
 > >  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- 
 > >  1 file changed, 1 insertion(+), 5 deletions(-) 
 > > 
 >  
 >  
 > Looks correct so for the patch itself: 
 > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> 
 >  
 > However, your name "Perr" confuses me a little bit. For the 
 > Signed-off-by statement, as mentioned in 
 > Documentation/SubmittingPatches, a real name is required. The name 
 > should match the author. 
 >  
 > Would you be so kind as to use a full, real name? Unless Perr is your 
 > full, real name... then sorry for the trouble. 
Perr Zhang <strongbox8@zoho.com>  is OK?
I'm from China. Perr is my first name in English.
 >  
 > Best regards, 
 > Krzysztof 
 >  
 > 

[toc] | [prev] | [next] | [standalone]

#1463430

On 08/16/2016 01:58 AM, perr perr wrote:
>  ---- On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote ---- 
>  > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: 
>  > > Because chained_irq_enter() has already called chip->irq_mask() and 
>  > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), 
>  > > so it's not necessary to call chip->irq_*() here. 
>  > >  
>  > > Signed-off-by: perr <strongbox8@zoho.com> 
>  > >  
>  > > --- 
>  > >  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- 
>  > >  1 file changed, 1 insertion(+), 5 deletions(-) 
>  > > 
>  >  
>  >  
>  > Looks correct so for the patch itself: 
>  > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> 
>  >  
>  > However, your name "Perr" confuses me a little bit. For the 
>  > Signed-off-by statement, as mentioned in 
>  > Documentation/SubmittingPatches, a real name is required. The name 
>  > should match the author. 
>  >  
>  > Would you be so kind as to use a full, real name? Unless Perr is your 
>  > full, real name... then sorry for the trouble. 
> Perr Zhang <strongbox8@zoho.com>  is OK?
> I'm from China. Perr is my first name in English.

Yes, seems fine. Could you resend with updated name?

Best regards,
Krzysztof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web