Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1456968 > unrolled thread

[PATCH 08/11] net/fsl: use of_property_read_bool

Started byJulia Lawall <Julia.Lawall@lip6.fr>
First post2016-08-05 11:20 +0200
Last post2016-08-05 13:50 +0200
Articles 10 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-05 11:20 +0200
    Re: [PATCH 08/11] net/fsl: use of_property_read_bool Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 11:40 +0200
      Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 11:50 +0200
      Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 12:10 +0200
        Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 12:20 +0200
        Re: [PATCH 08/11] net/fsl: use of_property_read_bool Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 12:40 +0200
    [PATCH 08/11 v2] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 13:30 +0200
    Re: [PATCH 08/11] net/fsl: use of_property_read_bool Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-05 13:40 +0200
      Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 13:40 +0200
        Re: [PATCH 08/11] net/fsl: use of_property_read_bool Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-05 13:50 +0200

#1456968 — [PATCH 08/11] net/fsl: use of_property_read_bool

FromJulia Lawall <Julia.Lawall@lip6.fr>
Date2016-08-05 11:20 +0200
Subject[PATCH 08/11] net/fsl: use of_property_read_bool
Message-ID<s2Jsm-5yi-25@gated-at.bofh.it>
Use of_property_read_bool to check for the existence of a property.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
-       if (of_get_property(e1,e2,NULL))
+       if (of_property_read_bool(e1,e2))
        S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/net/ethernet/freescale/xgmac_mdio.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 7b8fe86..a77ba98 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
 		goto err_ioremap;
 	}
 
-	if (of_get_property(pdev->dev.of_node,
-			    "little-endian", NULL))
+	if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
 		priv->is_little_endian = true;
 	else
 		priv->is_little_endian = false;

[toc] | [next] | [standalone]

#1456987

FromJohannes Berg <johannes@sipsolutions.net>
Date2016-08-05 11:40 +0200
Message-ID<s2JLH-5EJ-11@gated-at.bofh.it>
In reply to#1456968
> -	if (of_get_property(pdev->dev.of_node,
> -			    "little-endian", NULL))
> +	if (of_property_read_bool(pdev->dev.of_node, "little-
> endian"))
>  		priv->is_little_endian = true;
>  	else
>  		priv->is_little_endian = false;
> 

Perhaps, while changing this, that'd be better as

	priv->is_little_endian = of_property_read_bool(...);

Obviously that would've worked before, but now it'd be even easier to
understand, it seems.

johannes

[toc] | [prev] | [next] | [standalone]

#1456992

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-08-05 11:50 +0200
Message-ID<s2JVn-5I9-5@gated-at.bofh.it>
In reply to#1456987

[Multipart message — attachments visible in raw view] — view raw

On Fri, 5 Aug 2016, Johannes Berg wrote:

>
> > -	if (of_get_property(pdev->dev.of_node,
> > -			    "little-endian", NULL))
> > +	if (of_property_read_bool(pdev->dev.of_node, "little-
> > endian"))
> >  		priv->is_little_endian = true;
> >  	else
> >  		priv->is_little_endian = false;
> >
>
> Perhaps, while changing this, that'd be better as
>
> 	priv->is_little_endian = of_property_read_bool(...);
>
> Obviously that would've worked before, but now it'd be even easier to
> understand, it seems.

Thanks for the suggestion.  Will send shortly.

julia

[toc] | [prev] | [next] | [standalone]

#1456996

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-08-05 12:10 +0200
Message-ID<s2KeJ-65X-17@gated-at.bofh.it>
In reply to#1456987

[Multipart message — attachments visible in raw view] — view raw

On Fri, 5 Aug 2016, Johannes Berg wrote:

>
> > -	if (of_get_property(pdev->dev.of_node,
> > -			    "little-endian", NULL))
> > +	if (of_property_read_bool(pdev->dev.of_node, "little-
> > endian"))
> >  		priv->is_little_endian = true;
> >  	else
> >  		priv->is_little_endian = false;
> >
>
> Perhaps, while changing this, that'd be better as
>
> 	priv->is_little_endian = of_property_read_bool(...);
>
> Obviously that would've worked before, but now it'd be even easier to
> understand, it seems.

Can I do the same for:

	if (of_property_read_bool(np, "phy-clk-valid"))
                pdata->check_phy_clk_valid = 1;
	else
                pdata->check_phy_clk_valid = 0;

The type is not bool, but:

include/linux/fsl_devices.h:    unsigned        check_phy_clk_valid:1;

thanks,
julia

[toc] | [prev] | [next] | [standalone]

#1457003

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-08-05 12:20 +0200
Message-ID<s2Koq-69A-13@gated-at.bofh.it>
In reply to#1456996

[Multipart message — attachments visible in raw view] — view raw

On Fri, 5 Aug 2016, Johannes Berg wrote:

> On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
> > 
> > Can I do the same for:
> >
> >         if (of_property_read_bool(np, "phy-clk-valid"))
> >                 pdata->check_phy_clk_valid = 1;
> >         else
> >                 pdata->check_phy_clk_valid = 0;
> >
> > The type is not bool, but:
> >
> > include/linux/fsl_devices.h:    unsigned        check_phy_clk_valid:1;
> >
> The type doesn't even matter, does it? Any bool->int conversion should
> result in 0/1.

Just paranoid.  Thanks.

julia

[toc] | [prev] | [next] | [standalone]

#1457011

FromJohannes Berg <johannes@sipsolutions.net>
Date2016-08-05 12:40 +0200
Message-ID<s2Koq-69A-15@gated-at.bofh.it>
In reply to#1456996
On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
> 
> Can I do the same for:
> 
>         if (of_property_read_bool(np, "phy-clk-valid"))
>                 pdata->check_phy_clk_valid = 1;
>         else
>                 pdata->check_phy_clk_valid = 0;
> 
> The type is not bool, but:
> 
> include/linux/fsl_devices.h:    unsigned        check_phy_clk_valid:1;
> 
The type doesn't even matter, does it? Any bool->int conversion should
result in 0/1.

johannes

[toc] | [prev] | [next] | [standalone]

#1457036 — [PATCH 08/11 v2] net/fsl: use of_property_read_bool

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-08-05 13:30 +0200
Subject[PATCH 08/11 v2] net/fsl: use of_property_read_bool
Message-ID<s2Lua-6Rn-1@gated-at.bofh.it>
In reply to#1456968
Use of_property_read_bool to check for the existence of a property.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,x;
@@
-	if (of_get_property(e1,e2,NULL))
-		x = true;
-	else
-		x = false;
+	x = of_property_read_bool(e1,e2);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
v2: special case for propagating true and false

 drivers/net/ethernet/freescale/xgmac_mdio.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 7b8fe86..e03b30c 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -271,11 +271,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
 		goto err_ioremap;
 	}

-	if (of_get_property(pdev->dev.of_node,
-			    "little-endian", NULL))
-		priv->is_little_endian = true;
-	else
-		priv->is_little_endian = false;
+	priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
+						       "little-endian");

 	ret = of_mdiobus_register(bus, np);
 	if (ret) {

[toc] | [prev] | [next] | [standalone]

#1457041

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2016-08-05 13:40 +0200
Message-ID<s2LDQ-6UN-13@gated-at.bofh.it>
In reply to#1456968
Hello.

On 8/5/2016 11:56 AM, Julia Lawall wrote:

> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> -       if (of_get_property(e1,e2,NULL))
> +       if (of_property_read_bool(e1,e2))
>         S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>  drivers/net/ethernet/freescale/xgmac_mdio.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
> index 7b8fe86..a77ba98 100644
> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
> @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
>  		goto err_ioremap;
>  	}
>
> -	if (of_get_property(pdev->dev.of_node,
> -			    "little-endian", NULL))
> +	if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
>  		priv->is_little_endian = true;
>  	else
>  		priv->is_little_endian = false;

    priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
						  "little-endian"));

MBR, Sergei

[toc] | [prev] | [next] | [standalone]

#1457042

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-08-05 13:40 +0200
Message-ID<s2LDQ-6UN-21@gated-at.bofh.it>
In reply to#1457041

On Fri, 5 Aug 2016, Sergei Shtylyov wrote:

> Hello.
>
> On 8/5/2016 11:56 AM, Julia Lawall wrote:
>
> > Use of_property_read_bool to check for the existence of a property.
> >
> > The semantic patch that makes this change is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @@
> > expression e1,e2;
> > statement S2,S1;
> > @@
> > -       if (of_get_property(e1,e2,NULL))
> > +       if (of_property_read_bool(e1,e2))
> >         S1 else S2
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> >  drivers/net/ethernet/freescale/xgmac_mdio.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
> > b/drivers/net/ethernet/freescale/xgmac_mdio.c
> > index 7b8fe86..a77ba98 100644
> > --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
> > +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
> > @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device
> > *pdev)
> >  		goto err_ioremap;
> >  	}
> >
> > -	if (of_get_property(pdev->dev.of_node,
> > -			    "little-endian", NULL))
> > +	if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
> >  		priv->is_little_endian = true;
> >  	else
> >  		priv->is_little_endian = false;
>
>    priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
> 						  "little-endian"));

Thanks,

I just sent a v2 with this change.

julia

[toc] | [prev] | [next] | [standalone]

#1457047

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2016-08-05 13:50 +0200
Message-ID<s2LNw-6Yu-19@gated-at.bofh.it>
In reply to#1457042
On 8/5/2016 2:38 PM, Julia Lawall wrote:

>>> Use of_property_read_bool to check for the existence of a property.
>>>
>>> The semantic patch that makes this change is as follows:
>>> (http://coccinelle.lip6.fr/)
>>>
>>> // <smpl>
>>> @@
>>> expression e1,e2;
>>> statement S2,S1;
>>> @@
>>> -       if (of_get_property(e1,e2,NULL))
>>> +       if (of_property_read_bool(e1,e2))
>>>         S1 else S2
>>> // </smpl>
>>>
>>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>>>
>>> ---
>>>  drivers/net/ethernet/freescale/xgmac_mdio.c |    3 +--
>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> index 7b8fe86..a77ba98 100644
>>> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device
>>> *pdev)
>>>  		goto err_ioremap;
>>>  	}
>>>
>>> -	if (of_get_property(pdev->dev.of_node,
>>> -			    "little-endian", NULL))
>>> +	if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
>>>  		priv->is_little_endian = true;
>>>  	else
>>>  		priv->is_little_endian = false;
>>
>>    priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
>> 						  "little-endian"));
>
> Thanks,
>
> I just sent a v2 with this change.

    I've seen. Sorry, forgot to look at the followups before commenting...

> julia

MBR, Sergei

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web