Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1457036
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 08/11 v2] net/fsl: use of_property_read_bool |
| Date | 2016-08-05 13:30 +0200 |
| Message-ID | <s2Lua-6Rn-1@gated-at.bofh.it> (permalink) |
| References | <s2Jsl-5yi-3@gated-at.bofh.it> <s2Jsm-5yi-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,x;
@@
- if (of_get_property(e1,e2,NULL))
- x = true;
- else
- x = false;
+ x = of_property_read_bool(e1,e2);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
v2: special case for propagating true and false
drivers/net/ethernet/freescale/xgmac_mdio.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 7b8fe86..e03b30c 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -271,11 +271,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
goto err_ioremap;
}
- if (of_get_property(pdev->dev.of_node,
- "little-endian", NULL))
- priv->is_little_endian = true;
- else
- priv->is_little_endian = false;
+ priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
+ "little-endian");
ret = of_mdiobus_register(bus, np);
if (ret) {
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-05 11:20 +0200
Re: [PATCH 08/11] net/fsl: use of_property_read_bool Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 11:40 +0200
Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 11:50 +0200
Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 12:10 +0200
Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 12:20 +0200
Re: [PATCH 08/11] net/fsl: use of_property_read_bool Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 12:40 +0200
[PATCH 08/11 v2] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 13:30 +0200
Re: [PATCH 08/11] net/fsl: use of_property_read_bool Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-05 13:40 +0200
Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 13:40 +0200
Re: [PATCH 08/11] net/fsl: use of_property_read_bool Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-05 13:50 +0200
csiph-web