Re: [PATCH 08/11] net/fsl: use of_property_read_bool

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 08/11] net/fsl: use of_property_read_bool
Date	2016-08-05 13:50 +0200
Message-ID	<s2LNw-6Yu-19@gated-at.bofh.it> (permalink)
References	<s2Jsl-5yi-3@gated-at.bofh.it> <s2Jsm-5yi-25@gated-at.bofh.it> <s2LDQ-6UN-13@gated-at.bofh.it> <s2LDQ-6UN-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 8/5/2016 2:38 PM, Julia Lawall wrote:

>>> Use of_property_read_bool to check for the existence of a property.
>>>
>>> The semantic patch that makes this change is as follows:
>>> (http://coccinelle.lip6.fr/)
>>>
>>> // <smpl>
>>> @@
>>> expression e1,e2;
>>> statement S2,S1;
>>> @@
>>> -       if (of_get_property(e1,e2,NULL))
>>> +       if (of_property_read_bool(e1,e2))
>>>         S1 else S2
>>> // </smpl>
>>>
>>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>>>
>>> ---
>>>  drivers/net/ethernet/freescale/xgmac_mdio.c |    3 +--
>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> index 7b8fe86..a77ba98 100644
>>> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device
>>> *pdev)
>>>  		goto err_ioremap;
>>>  	}
>>>
>>> -	if (of_get_property(pdev->dev.of_node,
>>> -			    "little-endian", NULL))
>>> +	if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
>>>  		priv->is_little_endian = true;
>>>  	else
>>>  		priv->is_little_endian = false;
>>
>>    priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
>> 						  "little-endian"));
>
> Thanks,
>
> I just sent a v2 with this change.

    I've seen. Sorry, forgot to look at the followups before commenting...

> julia

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-05 11:20 +0200
  Re: [PATCH 08/11] net/fsl: use of_property_read_bool Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 11:40 +0200
    Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 11:50 +0200
    Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 12:10 +0200
      Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 12:20 +0200
      Re: [PATCH 08/11] net/fsl: use of_property_read_bool Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 12:40 +0200
  [PATCH 08/11 v2] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 13:30 +0200
  Re: [PATCH 08/11] net/fsl: use of_property_read_bool Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-05 13:40 +0200
    Re: [PATCH 08/11] net/fsl: use of_property_read_bool Julia Lawall <julia.lawall@lip6.fr> - 2016-08-05 13:40 +0200
      Re: [PATCH 08/11] net/fsl: use of_property_read_bool Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-05 13:50 +0200

csiph-web