Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452891 > unrolled thread

[PATCH 1/6] fs: befs: remove unneeded initialization to zero

Started bySalah Triki <salah.triki@gmail.com>
First post2016-07-31 22:40 +0200
Last post2016-08-01 15:00 +0200
Articles 8 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/6] fs: befs: remove unneeded initialization to zero Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
    [PATCH 3/6] fs: befs: remove useless initialization to zero Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
      Re: [PATCH 3/6] fs: befs: remove useless initialization to zero Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 15:50 +0200
        Re: [PATCH 3/6] fs: befs: remove useless initialization to zero Salah Triki <salah.triki@gmail.com> - 2016-08-06 23:10 +0200
    [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
      Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 16:10 +0200
        Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Salah Triki <salah.triki@gmail.com> - 2016-08-06 22:40 +0200
    Re: [PATCH 1/6] fs: befs: remove unneeded initialization to zero Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 15:00 +0200

#1452891 — [PATCH 1/6] fs: befs: remove unneeded initialization to zero

FromSalah Triki <salah.triki@gmail.com>
Date2016-07-31 22:40 +0200
Subject[PATCH 1/6] fs: befs: remove unneeded initialization to zero
Message-ID<s15GF-4Uk-7@gated-at.bofh.it>
off is reinitialized by befs_read_datastream, so no need to init it with
zero in the beginning of befs_bt_read_node.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
 fs/befs/btree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/befs/btree.c b/fs/befs/btree.c
index e59ad20..a0e8cfa 100644
--- a/fs/befs/btree.c
+++ b/fs/befs/btree.c
@@ -196,7 +196,7 @@ static int
 befs_bt_read_node(struct super_block *sb, const befs_data_stream *ds,
 		  struct befs_btree_node *node, befs_off_t node_off)
 {
-	uint off = 0;
+	uint off;
 
 	befs_debug(sb, "---> %s", __func__);
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1452892 — [PATCH 3/6] fs: befs: remove useless initialization to zero

FromSalah Triki <salah.triki@gmail.com>
Date2016-07-31 22:40 +0200
Subject[PATCH 3/6] fs: befs: remove useless initialization to zero
Message-ID<s15GF-4Uk-11@gated-at.bofh.it>
In reply to#1452891
node_off is unconditionally set to bt_super.root_node_ptr, so no need to
init it to zero.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
 fs/befs/btree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/befs/btree.c b/fs/befs/btree.c
index f33fc6c..3cb97e8 100644
--- a/fs/befs/btree.c
+++ b/fs/befs/btree.c
@@ -420,7 +420,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
 {
 	struct befs_btree_node *this_node;
 	befs_btree_super bt_super;
-	befs_off_t node_off = 0;
+	befs_off_t node_off;
 	int cur_key;
 	fs64 *valarray;
 	char *keystart;
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1453215 — Re: [PATCH 3/6] fs: befs: remove useless initialization to zero

FromLuis de Bethencourt <luisbg@osg.samsung.com>
Date2016-08-01 15:50 +0200
SubjectRe: [PATCH 3/6] fs: befs: remove useless initialization to zero
Message-ID<s1lLr-702-3@gated-at.bofh.it>
In reply to#1452892
On 31/07/16 21:34, Salah Triki wrote:
> node_off is unconditionally set to bt_super.root_node_ptr, so no need to
> init it to zero.
> 
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
>  fs/befs/btree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> index f33fc6c..3cb97e8 100644
> --- a/fs/befs/btree.c
> +++ b/fs/befs/btree.c
> @@ -420,7 +420,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
>  {
>  	struct befs_btree_node *this_node;
>  	befs_btree_super bt_super;
> -	befs_off_t node_off = 0;
> +	befs_off_t node_off;
>  	int cur_key;
>  	fs64 *valarray;
>  	char *keystart;
> 

Looks good to me.

Strange that static analysis didn't pick this one up before.

Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Pushed to the befs-next branch:
https://github.com/luisbg/linux-befs/tree/befs-next

Thanks Salah,
Luis

[toc] | [prev] | [next] | [standalone]

#1457362 — Re: [PATCH 3/6] fs: befs: remove useless initialization to zero

FromSalah Triki <salah.triki@gmail.com>
Date2016-08-06 23:10 +0200
SubjectRe: [PATCH 3/6] fs: befs: remove useless initialization to zero
Message-ID<s3h0Z-2zz-15@gated-at.bofh.it>
In reply to#1453215
On Mon, Aug 01, 2016 at 02:44:18PM +0100, Luis de Bethencourt wrote:
> On 31/07/16 21:34, Salah Triki wrote:
> > node_off is unconditionally set to bt_super.root_node_ptr, so no need to
> > init it to zero.
> > 
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
> >  fs/befs/btree.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> > index f33fc6c..3cb97e8 100644
> > --- a/fs/befs/btree.c
> > +++ b/fs/befs/btree.c
> > @@ -420,7 +420,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
> >  {
> >  	struct befs_btree_node *this_node;
> >  	befs_btree_super bt_super;
> > -	befs_off_t node_off = 0;
> > +	befs_off_t node_off;
> >  	int cur_key;
> >  	fs64 *valarray;
> >  	char *keystart;
> > 
> 
> Looks good to me.
> 
> Strange that static analysis didn't pick this one up before.
> 
> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> 
> Pushed to the befs-next branch:
> https://github.com/luisbg/linux-befs/tree/befs-next
> 
> Thanks Salah,
> Luis

Thanx :)
Salah

[toc] | [prev] | [next] | [standalone]

#1452893 — [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable

FromSalah Triki <salah.triki@gmail.com>
Date2016-07-31 22:40 +0200
Subject[PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable
Message-ID<s15GG-4Uk-23@gated-at.bofh.it>
In reply to#1452891
Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned
value by this function is only used once.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
 fs/befs/datastream.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c
index b68b6f9..343123c 100644
--- a/fs/befs/datastream.c
+++ b/fs/befs/datastream.c
@@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb,
 	struct buffer_head *indir_block;
 	befs_block_run indir_run;
 	befs_disk_inode_addr *iaddr_array;
-	struct befs_sb_info *befs_sb = BEFS_SB(sb);
 
 	befs_blocknr_t indir_start_blk =
-	    data->max_indirect_range >> befs_sb->block_shift;
+	    data->max_indirect_range >> BEFS_SB(sb)->block_shift;
 
 	off_t dbl_indir_off = blockno - indir_start_blk;
 
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1453230 — Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable

FromLuis de Bethencourt <luisbg@osg.samsung.com>
Date2016-08-01 16:10 +0200
SubjectRe: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable
Message-ID<s1m4O-7lR-21@gated-at.bofh.it>
In reply to#1452893
On 31/07/16 21:34, Salah Triki wrote:
> Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned
> value by this function is only used once.
> 
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
>  fs/befs/datastream.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c
> index b68b6f9..343123c 100644
> --- a/fs/befs/datastream.c
> +++ b/fs/befs/datastream.c
> @@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb,
>  	struct buffer_head *indir_block;
>  	befs_block_run indir_run;
>  	befs_disk_inode_addr *iaddr_array;
> -	struct befs_sb_info *befs_sb = BEFS_SB(sb);
>  
>  	befs_blocknr_t indir_start_blk =
> -	    data->max_indirect_range >> befs_sb->block_shift;
> +	    data->max_indirect_range >> BEFS_SB(sb)->block_shift;
>  
>  	off_t dbl_indir_off = blockno - indir_start_blk;
>  
> 

This looks to be consistent with other uses of BEFS_SB() when the value is
only used once.

Thanks,
Luis

Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Pushed to the befs-next branch:
https://github.com/luisbg/linux-befs/tree/befs-next

[toc] | [prev] | [next] | [standalone]

#1457340 — Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable

FromSalah Triki <salah.triki@gmail.com>
Date2016-08-06 22:40 +0200
SubjectRe: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable
Message-ID<s3gxX-29J-13@gated-at.bofh.it>
In reply to#1453230
On Mon, Aug 01, 2016 at 03:02:57PM +0100, Luis de Bethencourt wrote:
> On 31/07/16 21:34, Salah Triki wrote:
> > Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned
> > value by this function is only used once.
> > 
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
> >  fs/befs/datastream.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c
> > index b68b6f9..343123c 100644
> > --- a/fs/befs/datastream.c
> > +++ b/fs/befs/datastream.c
> > @@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb,
> >  	struct buffer_head *indir_block;
> >  	befs_block_run indir_run;
> >  	befs_disk_inode_addr *iaddr_array;
> > -	struct befs_sb_info *befs_sb = BEFS_SB(sb);
> >  
> >  	befs_blocknr_t indir_start_blk =
> > -	    data->max_indirect_range >> befs_sb->block_shift;
> > +	    data->max_indirect_range >> BEFS_SB(sb)->block_shift;
> >  
> >  	off_t dbl_indir_off = blockno - indir_start_blk;
> >  
> > 
> 
> This looks to be consistent with other uses of BEFS_SB() when the value is
> only used once.
> 
> Thanks,
> Luis
> 
> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> 
> Pushed to the befs-next branch:
> https://github.com/luisbg/linux-befs/tree/befs-next

Thanx :)
salah

[toc] | [prev] | [next] | [standalone]

#1453196

FromLuis de Bethencourt <luisbg@osg.samsung.com>
Date2016-08-01 15:00 +0200
Message-ID<s1kZ3-6qC-13@gated-at.bofh.it>
In reply to#1452891
On 31/07/16 21:34, Salah Triki wrote:
> off is reinitialized by befs_read_datastream, so no need to init it with
> zero in the beginning of befs_bt_read_node.
> 
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
>  fs/befs/btree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> index e59ad20..a0e8cfa 100644
> --- a/fs/befs/btree.c
> +++ b/fs/befs/btree.c
> @@ -196,7 +196,7 @@ static int
>  befs_bt_read_node(struct super_block *sb, const befs_data_stream *ds,
>  		  struct befs_btree_node *node, befs_off_t node_off)
>  {
> -	uint off = 0;
> +	uint off;
>  
>  	befs_debug(sb, "---> %s", __func__);
>  
> 

Hi Salah,

I will quote Andrew here:
"With this code:

	int foo;

	bar(&foo);

	whatever = foo;

some versions of gcc will warn that foo might be used uninitialized. 
Other versions of gcc don't do this.  That's why the seemingly-unneeded
initializations are there."

You can read the rest of his reply to when I sent the same change 2
months ago :)

https://lkml.org/lkml/2016/6/1/875

Sorry, I agree with him to keep the code as it is.

Nacked.

Thanks,
Luis

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web