Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable

From	Salah Triki <salah.triki@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable
Date	2016-08-06 22:40 +0200
Message-ID	<s3gxX-29J-13@gated-at.bofh.it> (permalink)
References	<s15GF-4Uk-7@gated-at.bofh.it> <s15GG-4Uk-23@gated-at.bofh.it> <s1m4O-7lR-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 01, 2016 at 03:02:57PM +0100, Luis de Bethencourt wrote:
> On 31/07/16 21:34, Salah Triki wrote:
> > Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned
> > value by this function is only used once.
> > 
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
> >  fs/befs/datastream.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c
> > index b68b6f9..343123c 100644
> > --- a/fs/befs/datastream.c
> > +++ b/fs/befs/datastream.c
> > @@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb,
> >  	struct buffer_head *indir_block;
> >  	befs_block_run indir_run;
> >  	befs_disk_inode_addr *iaddr_array;
> > -	struct befs_sb_info *befs_sb = BEFS_SB(sb);
> >  
> >  	befs_blocknr_t indir_start_blk =
> > -	    data->max_indirect_range >> befs_sb->block_shift;
> > +	    data->max_indirect_range >> BEFS_SB(sb)->block_shift;
> >  
> >  	off_t dbl_indir_off = blockno - indir_start_blk;
> >  
> > 
> 
> This looks to be consistent with other uses of BEFS_SB() when the value is
> only used once.
> 
> Thanks,
> Luis
> 
> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> 
> Pushed to the befs-next branch:
> https://github.com/luisbg/linux-befs/tree/befs-next

Thanx :)
salah

Thread

[PATCH 1/6] fs: befs: remove unneeded initialization to zero Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
  [PATCH 3/6] fs: befs: remove useless initialization to zero Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
    Re: [PATCH 3/6] fs: befs: remove useless initialization to zero Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 15:50 +0200
      Re: [PATCH 3/6] fs: befs: remove useless initialization to zero Salah Triki <salah.triki@gmail.com> - 2016-08-06 23:10 +0200
  [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
    Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 16:10 +0200
      Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Salah Triki <salah.triki@gmail.com> - 2016-08-06 22:40 +0200
  Re: [PATCH 1/6] fs: befs: remove unneeded initialization to zero Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 15:00 +0200

csiph-web