Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1453215
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/6] fs: befs: remove useless initialization to zero |
| Date | 2016-08-01 15:50 +0200 |
| Message-ID | <s1lLr-702-3@gated-at.bofh.it> (permalink) |
| References | <s15GF-4Uk-7@gated-at.bofh.it> <s15GF-4Uk-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 31/07/16 21:34, Salah Triki wrote:
> node_off is unconditionally set to bt_super.root_node_ptr, so no need to
> init it to zero.
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> fs/befs/btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> index f33fc6c..3cb97e8 100644
> --- a/fs/befs/btree.c
> +++ b/fs/befs/btree.c
> @@ -420,7 +420,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
> {
> struct befs_btree_node *this_node;
> befs_btree_super bt_super;
> - befs_off_t node_off = 0;
> + befs_off_t node_off;
> int cur_key;
> fs64 *valarray;
> char *keystart;
>
Looks good to me.
Strange that static analysis didn't pick this one up before.
Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Pushed to the befs-next branch:
https://github.com/luisbg/linux-befs/tree/befs-next
Thanks Salah,
Luis
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/6] fs: befs: remove unneeded initialization to zero Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
[PATCH 3/6] fs: befs: remove useless initialization to zero Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
Re: [PATCH 3/6] fs: befs: remove useless initialization to zero Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 15:50 +0200
Re: [PATCH 3/6] fs: befs: remove useless initialization to zero Salah Triki <salah.triki@gmail.com> - 2016-08-06 23:10 +0200
[PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 16:10 +0200
Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Salah Triki <salah.triki@gmail.com> - 2016-08-06 22:40 +0200
Re: [PATCH 1/6] fs: befs: remove unneeded initialization to zero Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 15:00 +0200
csiph-web