Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1387339 > unrolled thread
| Started by | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| First post | 2016-04-26 12:30 +0200 |
| Last post | 2016-04-26 20:30 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-04-26 12:30 +0200
Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag David Miller <davem@davemloft.net> - 2016-04-26 19:20 +0200
Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-26 20:30 +0200
Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-04-27 09:20 +0200
Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-26 20:30 +0200
| From | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| Date | 2016-04-26 12:30 +0200 |
| Subject | [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag |
| Message-ID | <rs8pI-5ZZ-23@gated-at.bofh.it> |
Fix gpio active flag for the phy reset-gpios property. The line is
active low instead of active high.
Actually, this flags was never used by the macb driver.
Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Hi,
Thanks for having reported this bug to me.
I hope that we will be able to move forward for changing the phy
reset code in the macb driver.
I plan to queue this patch through arm-soc for 4.7.
Thanks, best regards,
Nicolas
arch/arm/boot/dts/at91-vinco.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/at91-vinco.dts b/arch/arm/boot/dts/at91-vinco.dts
index 79aec55e1ebc..6a366ee952a8 100644
--- a/arch/arm/boot/dts/at91-vinco.dts
+++ b/arch/arm/boot/dts/at91-vinco.dts
@@ -118,7 +118,7 @@
ethernet-phy@1 {
reg = <0x1>;
- reset-gpios = <&pioE 8 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&pioE 8 GPIO_ACTIVE_LOW>;
interrupt-parent = <&pioB>;
interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
};
@@ -162,7 +162,7 @@
reg = <0x1>;
interrupt-parent = <&pioB>;
interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
- reset-gpios = <&pioE 6 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&pioE 6 GPIO_ACTIVE_LOW>;
};
};
--
2.1.3
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-04-26 19:20 +0200 |
| Message-ID | <rseOu-2Z1-15@gated-at.bofh.it> |
| In reply to | #1387339 |
From: Nicolas Ferre <nicolas.ferre@atmel.com> Date: Tue, 26 Apr 2016 12:24:32 +0200 > I plan to queue this patch through arm-soc for 4.7. Ok.
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-04-26 20:30 +0200 |
| Message-ID | <rsfUe-3TD-25@gated-at.bofh.it> |
| In reply to | #1387731 |
On 04/26/2016 08:17 PM, David Miller wrote:
>> I plan to queue this patch through arm-soc for 4.7.
>
> Ok.
How about this patch going thru your net-next repo instead?
I'd like to keep the kernel bisectable... if my phylib/macb patches get merged
earlier than this one, that board would be broken...
MBR, Sergei
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| Date | 2016-04-27 09:20 +0200 |
| Message-ID | <rsrVo-5zE-9@gated-at.bofh.it> |
| In reply to | #1387807 |
Le 26/04/2016 20:27, Sergei Shtylyov a écrit : > On 04/26/2016 08:17 PM, David Miller wrote: > >>> I plan to queue this patch through arm-soc for 4.7. >> >> Ok. > > How about this patch going thru your net-next repo instead? > I'd like to keep the kernel bisectable... if my phylib/macb patches get merged > earlier than this one, that board would be broken... Sergei, David, I don't think that there is a big risk for this board to be tested in the meantime as it's not widely deployed yet. And as I'm aware of the issue and basically maintaining this DT file, I think that I'll be informed if people try an unlikely arrangement of patches on this board. So either way, I'm okay. But I do think it's not worth thinking too much about this case. Bye, -- Nicolas Ferre
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-04-26 20:30 +0200 |
| Message-ID | <rsfUi-3TD-127@gated-at.bofh.it> |
| In reply to | #1387339 |
Hello.
On 04/26/2016 01:24 PM, Nicolas Ferre wrote:
> Fix gpio active flag for the phy reset-gpios property. The line is
> active low instead of active high.
> Actually, this flags was never used by the macb driver.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: David Miller <davem@davemloft.net>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Hi,
>
> Thanks for having reported this bug to me.
And thank you for beating me to it and doing the patch. I'm still busy
with other stuff. :-(
> I hope that we will be able to move forward for changing the phy
> reset code in the macb driver.
I meant to delete it entirely.
> I plan to queue this patch through arm-soc for 4.7.
Hm, that way we get that board broken if my phylib/macb patches get merged
before your patch. Perhaps it would be better to merge this patch thru DaveM's
tree (before my patches) to keep the kernel bisectable?
> Thanks, best regards,
> Nicolas
MBR, Sergei
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web