Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1387838

Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

Show all headers | View raw

Hello.

On 04/26/2016 01:24 PM, Nicolas Ferre wrote:

> Fix gpio active flag for the phy reset-gpios property. The line is
> active low instead of active high.
> Actually, this flags was never used by the macb driver.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: David Miller <davem@davemloft.net>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Hi,
>
> Thanks for having reported this bug to me.

    And thank you for beating me to it and doing the patch. I'm still busy 
with other stuff. :-(

> I hope that we will be able to move forward for changing the phy
> reset code in the macb driver.

    I meant to delete it entirely.

> I plan to queue this patch through arm-soc for 4.7.

    Hm, that way we get that board broken if my phylib/macb patches get merged 
before your patch. Perhaps it would be better to merge this patch thru DaveM's 
tree (before my patches) to keep the kernel bisectable?

> Thanks, best regards,
>    Nicolas

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-04-26 12:30 +0200
  Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag David Miller <davem@davemloft.net> - 2016-04-26 19:20 +0200
    Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-26 20:30 +0200
      Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-04-27 09:20 +0200
  Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-26 20:30 +0200

csiph-web