[PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

From	Nicolas Ferre <nicolas.ferre@atmel.com>
Newsgroups	linux.kernel
Subject	[PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag
Date	2016-04-26 12:30 +0200
Message-ID	<rs8pI-5ZZ-23@gated-at.bofh.it> (permalink)
References	<rmPnI-2oc-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Fix gpio active flag for the phy reset-gpios property. The line is
active low instead of active high.
Actually, this flags was never used by the macb driver.

Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Hi,

Thanks for having reported this bug to me.
I hope that we will be able to move forward for changing the phy
reset code in the macb driver.

I plan to queue this patch through arm-soc for 4.7.

Thanks, best regards,
  Nicolas

 arch/arm/boot/dts/at91-vinco.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91-vinco.dts b/arch/arm/boot/dts/at91-vinco.dts
index 79aec55e1ebc..6a366ee952a8 100644
--- a/arch/arm/boot/dts/at91-vinco.dts
+++ b/arch/arm/boot/dts/at91-vinco.dts
@@ -118,7 +118,7 @@
 
 				ethernet-phy@1 {
 					reg = <0x1>;
-					reset-gpios = <&pioE 8 GPIO_ACTIVE_HIGH>;
+					reset-gpios = <&pioE 8 GPIO_ACTIVE_LOW>;
 					interrupt-parent = <&pioB>;
 					interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
 				};
@@ -162,7 +162,7 @@
 					reg = <0x1>;
 					interrupt-parent = <&pioB>;
 					interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
-					reset-gpios = <&pioE 6 GPIO_ACTIVE_HIGH>;
+					reset-gpios = <&pioE 6 GPIO_ACTIVE_LOW>;
 				};
 			};
 
-- 
2.1.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-04-26 12:30 +0200
  Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag David Miller <davem@davemloft.net> - 2016-04-26 19:20 +0200
    Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-26 20:30 +0200
      Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-04-27 09:20 +0200
  Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-26 20:30 +0200

csiph-web