Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1381775 > unrolled thread
| Started by | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| First post | 2016-04-18 16:50 +0200 |
| Last post | 2016-04-19 09:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity() Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-18 16:50 +0200
Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-18 17:00 +0200
Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity() Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-19 09:10 +0200
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Date | 2016-04-18 16:50 +0200 |
| Subject | [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity() |
| Message-ID | <rpiEW-7e9-23@gated-at.bofh.it> |
Parameters delay_on and delay_off of led_trigger_blink_oneshot()
are pointers, to enable blink interval adjustment by LED class drivers
of the controllers that implement hardware blinking.
Move ide_blink_delay variable to ledtrig_ide_activity() in order to
prevent the situation when adjustment committed by one LED class
driver influences blink interval of the software fallback blink feature,
that is applied to the drivers that don't implement blink_set op.
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
drivers/leds/trigger/ledtrig-ide-disk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/trigger/ledtrig-ide-disk.c b/drivers/leds/trigger/ledtrig-ide-disk.c
index c02a3ac..15123d3 100644
--- a/drivers/leds/trigger/ledtrig-ide-disk.c
+++ b/drivers/leds/trigger/ledtrig-ide-disk.c
@@ -18,10 +18,11 @@
#define BLINK_DELAY 30
DEFINE_LED_TRIGGER(ledtrig_ide);
-static unsigned long ide_blink_delay = BLINK_DELAY;
void ledtrig_ide_activity(void)
{
+ unsigned long ide_blink_delay = BLINK_DELAY;
+
led_trigger_blink_oneshot(ledtrig_ide,
&ide_blink_delay, &ide_blink_delay, 0);
}
--
1.7.9.5
[toc] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2016-04-18 17:00 +0200 |
| Message-ID | <rpiOC-7ii-19@gated-at.bofh.it> |
| In reply to | #1381775 |
On Mon, 18 Apr 2016 16:40:46 +0200
Jacek Anaszewski <j.anaszewski@samsung.com> wrote:
> Parameters delay_on and delay_off of led_trigger_blink_oneshot()
> are pointers, to enable blink interval adjustment by LED class drivers
> of the controllers that implement hardware blinking.
>
> Move ide_blink_delay variable to ledtrig_ide_activity() in order to
> prevent the situation when adjustment committed by one LED class
> driver influences blink interval of the software fallback blink feature,
> that is applied to the drivers that don't implement blink_set op.
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/leds/trigger/ledtrig-ide-disk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/trigger/ledtrig-ide-disk.c b/drivers/leds/trigger/ledtrig-ide-disk.c
> index c02a3ac..15123d3 100644
> --- a/drivers/leds/trigger/ledtrig-ide-disk.c
> +++ b/drivers/leds/trigger/ledtrig-ide-disk.c
> @@ -18,10 +18,11 @@
> #define BLINK_DELAY 30
>
> DEFINE_LED_TRIGGER(ledtrig_ide);
> -static unsigned long ide_blink_delay = BLINK_DELAY;
>
> void ledtrig_ide_activity(void)
> {
> + unsigned long ide_blink_delay = BLINK_DELAY;
> +
> led_trigger_blink_oneshot(ledtrig_ide,
> &ide_blink_delay, &ide_blink_delay, 0);
> }
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Date | 2016-04-19 09:10 +0200 |
| Message-ID | <rpxXk-2U7-17@gated-at.bofh.it> |
| In reply to | #1381783 |
Hi Boris, Thanks for the review, patch applied. Best regards, Jacek Anaszewski On 04/18/2016 04:57 PM, Boris Brezillon wrote: > On Mon, 18 Apr 2016 16:40:46 +0200 > Jacek Anaszewski <j.anaszewski@samsung.com> wrote: > >> Parameters delay_on and delay_off of led_trigger_blink_oneshot() >> are pointers, to enable blink interval adjustment by LED class drivers >> of the controllers that implement hardware blinking. >> >> Move ide_blink_delay variable to ledtrig_ide_activity() in order to >> prevent the situation when adjustment committed by one LED class >> driver influences blink interval of the software fallback blink feature, >> that is applied to the drivers that don't implement blink_set op. >> >> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > > Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web