Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity()

From	Jacek Anaszewski <j.anaszewski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity()
Date	2016-04-19 09:10 +0200
Message-ID	<rpxXk-2U7-17@gated-at.bofh.it> (permalink)
References	<rpiEW-7e9-23@gated-at.bofh.it> <rpiOC-7ii-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Boris,

Thanks for the review, patch applied.

Best regards,
Jacek Anaszewski

On 04/18/2016 04:57 PM, Boris Brezillon wrote:
> On Mon, 18 Apr 2016 16:40:46 +0200
> Jacek Anaszewski <j.anaszewski@samsung.com> wrote:
>
>> Parameters delay_on and delay_off of led_trigger_blink_oneshot()
>> are pointers, to enable blink interval adjustment by LED class drivers
>> of the controllers that implement hardware blinking.
>>
>> Move ide_blink_delay variable to ledtrig_ide_activity() in order to
>> prevent the situation when adjustment committed by one LED class
>> driver influences blink interval of the software fallback blink feature,
>> that is applied to the drivers that don't implement blink_set op.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to  ledtrig_ide_activity() Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-18 16:50 +0200
  Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to  ledtrig_ide_activity() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-18 17:00 +0200
    Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to  ledtrig_ide_activity() Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-19 09:10 +0200

csiph-web