Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1381775

[PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity()

Show all headers | View raw

Parameters delay_on and delay_off of led_trigger_blink_oneshot()
are pointers, to enable blink interval adjustment by LED class drivers
of the controllers that implement hardware blinking.

Move ide_blink_delay variable to ledtrig_ide_activity() in order to
prevent the situation when adjustment committed by one LED class
driver influences blink interval of the software fallback blink feature,
that is applied to the drivers that don't implement blink_set op.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
 drivers/leds/trigger/ledtrig-ide-disk.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/trigger/ledtrig-ide-disk.c b/drivers/leds/trigger/ledtrig-ide-disk.c
index c02a3ac..15123d3 100644
--- a/drivers/leds/trigger/ledtrig-ide-disk.c
+++ b/drivers/leds/trigger/ledtrig-ide-disk.c
@@ -18,10 +18,11 @@
 #define BLINK_DELAY 30
 
 DEFINE_LED_TRIGGER(ledtrig_ide);
-static unsigned long ide_blink_delay = BLINK_DELAY;
 
 void ledtrig_ide_activity(void)
 {
+	unsigned long ide_blink_delay = BLINK_DELAY;
+
 	led_trigger_blink_oneshot(ledtrig_ide,
 				  &ide_blink_delay, &ide_blink_delay, 0);
 }
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to  ledtrig_ide_activity() Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-18 16:50 +0200
  Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to  ledtrig_ide_activity() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-18 17:00 +0200
    Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to  ledtrig_ide_activity() Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-19 09:10 +0200

csiph-web