Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1370865 > unrolled thread
| Started by | Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> |
|---|---|
| First post | 2016-04-04 22:30 +0200 |
| Last post | 2016-04-06 18:20 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-04 22:30 +0200
Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2016-04-05 23:40 +0200
Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-06 06:40 +0200
Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Rob Herring <robh@kernel.org> - 2016-04-06 17:20 +0200
Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-06 18:20 +0200
| From | Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> |
|---|---|
| Date | 2016-04-04 22:30 +0200 |
| Subject | [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property |
| Message-ID | <rkjij-dT-31@gated-at.bofh.it> |
It's desirable to specify which LEDs are to be blinked on a kernel
panic. Therefore, introduce a devicetree boolean property to mark
which LEDs should be treated this way.
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
Documentation/devicetree/bindings/leds/common.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
index 68419843e32f..dd409df9203a 100644
--- a/Documentation/devicetree/bindings/leds/common.txt
+++ b/Documentation/devicetree/bindings/leds/common.txt
@@ -37,6 +37,8 @@ Optional properties for child nodes:
property is mandatory for the LEDs in the non-flash modes
(e.g. torch or indicator).
+- panic-blink : Mark this LED to be used by the panic LED trigger.
+
Required properties for flash LED child nodes:
- flash-max-microamp : Maximum flash LED supply current in microamperes.
- flash-max-timeout-us : Maximum timeout in microseconds after which the flash
--
2.7.0
[toc] | [next] | [standalone]
| From | Jacek Anaszewski <jacek.anaszewski@gmail.com> |
|---|---|
| Date | 2016-04-05 23:40 +0200 |
| Subject | Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property |
| Message-ID | <rkGRB-1Og-41@gated-at.bofh.it> |
| In reply to | #1370865 |
Hi Ezequiel, On 04/04/2016 10:22 PM, Ezequiel Garcia wrote: > It's desirable to specify which LEDs are to be blinked on a kernel > panic. Therefore, introduce a devicetree boolean property to mark > which LEDs should be treated this way. > > Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > --- > Documentation/devicetree/bindings/leds/common.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index 68419843e32f..dd409df9203a 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -37,6 +37,8 @@ Optional properties for child nodes: > property is mandatory for the LEDs in the non-flash modes > (e.g. torch or indicator). > > +- panic-blink : Mark this LED to be used by the panic LED trigger. I'd say that 'panic-indicator' would be more informative. Please next time cc also devicetree list and maintainers. > + > Required properties for flash LED child nodes: > - flash-max-microamp : Maximum flash LED supply current in microamperes. > - flash-max-timeout-us : Maximum timeout in microseconds after which the flash > -- Best regards, Jacek Anaszewski
[toc] | [prev] | [next] | [standalone]
| From | Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> |
|---|---|
| Date | 2016-04-06 06:40 +0200 |
| Message-ID | <rkNq1-6TB-5@gated-at.bofh.it> |
| In reply to | #1371978 |
On 5 April 2016 at 18:37, Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote: > Hi Ezequiel, > > On 04/04/2016 10:22 PM, Ezequiel Garcia wrote: >> >> It's desirable to specify which LEDs are to be blinked on a kernel >> panic. Therefore, introduce a devicetree boolean property to mark >> which LEDs should be treated this way. >> >> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> >> --- >> Documentation/devicetree/bindings/leds/common.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/common.txt >> b/Documentation/devicetree/bindings/leds/common.txt >> index 68419843e32f..dd409df9203a 100644 >> --- a/Documentation/devicetree/bindings/leds/common.txt >> +++ b/Documentation/devicetree/bindings/leds/common.txt >> @@ -37,6 +37,8 @@ Optional properties for child nodes: >> property is mandatory for the LEDs in the non-flash >> modes >> (e.g. torch or indicator). >> >> +- panic-blink : Mark this LED to be used by the panic LED trigger. > > > I'd say that 'panic-indicator' would be more informative. > Sure, that looks much better. > Please next time cc also devicetree list and maintainers. > Will do. Thanks for the reviews! -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-04-06 17:20 +0200 |
| Message-ID | <rkXpo-5RF-27@gated-at.bofh.it> |
| In reply to | #1370865 |
On Mon, Apr 4, 2016 at 3:22 PM, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote: > It's desirable to specify which LEDs are to be blinked on a kernel > panic. Therefore, introduce a devicetree boolean property to mark > which LEDs should be treated this way. > > Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > --- > Documentation/devicetree/bindings/leds/common.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index 68419843e32f..dd409df9203a 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -37,6 +37,8 @@ Optional properties for child nodes: > property is mandatory for the LEDs in the non-flash modes > (e.g. torch or indicator). > > +- panic-blink : Mark this LED to be used by the panic LED trigger. > + We already have a way to specify LED triggers. Why can't that be used? Rob
[toc] | [prev] | [next] | [standalone]
| From | Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> |
|---|---|
| Date | 2016-04-06 18:20 +0200 |
| Message-ID | <rkYlr-6yQ-3@gated-at.bofh.it> |
| In reply to | #1372601 |
On 6 April 2016 at 12:12, Rob Herring <robh@kernel.org> wrote: > On Mon, Apr 4, 2016 at 3:22 PM, Ezequiel Garcia > <ezequiel@vanguardiasur.com.ar> wrote: >> It's desirable to specify which LEDs are to be blinked on a kernel >> panic. Therefore, introduce a devicetree boolean property to mark >> which LEDs should be treated this way. >> >> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> >> --- >> Documentation/devicetree/bindings/leds/common.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt >> index 68419843e32f..dd409df9203a 100644 >> --- a/Documentation/devicetree/bindings/leds/common.txt >> +++ b/Documentation/devicetree/bindings/leds/common.txt >> @@ -37,6 +37,8 @@ Optional properties for child nodes: >> property is mandatory for the LEDs in the non-flash modes >> (e.g. torch or indicator). >> >> +- panic-blink : Mark this LED to be used by the panic LED trigger. >> + > > We already have a way to specify LED triggers. Why can't that be used? > Because this is not about specifying a LED trigger. The use case is the following: a LED is assigned to some LED trigger. When the kernel panics, we want to switch that LED to the panic trigger, so it blinks signalling the panic. IOW, this allows a LED to be used for "normal operation stuff trigger", but blink if the kernel panics. -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web