Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property

From	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property
Date	2016-04-06 18:20 +0200
Message-ID	<rkYlr-6yQ-3@gated-at.bofh.it> (permalink)
References	<rkjih-dT-7@gated-at.bofh.it> <rkjij-dT-31@gated-at.bofh.it> <rkXpo-5RF-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 6 April 2016 at 12:12, Rob Herring <robh@kernel.org> wrote:
> On Mon, Apr 4, 2016 at 3:22 PM, Ezequiel Garcia
> <ezequiel@vanguardiasur.com.ar> wrote:
>> It's desirable to specify which LEDs are to be blinked on a kernel
>> panic. Therefore, introduce a devicetree boolean property to mark
>> which LEDs should be treated this way.
>>
>> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
>> ---
>>  Documentation/devicetree/bindings/leds/common.txt | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
>> index 68419843e32f..dd409df9203a 100644
>> --- a/Documentation/devicetree/bindings/leds/common.txt
>> +++ b/Documentation/devicetree/bindings/leds/common.txt
>> @@ -37,6 +37,8 @@ Optional properties for child nodes:
>>                       property is mandatory for the LEDs in the non-flash modes
>>                       (e.g. torch or indicator).
>>
>> +- panic-blink : Mark this LED to be used by the panic LED trigger.
>> +
>
> We already have a way to specify LED triggers. Why can't that be used?
>

Because this is not about specifying a LED trigger.

The use case is the following: a LED is assigned to some LED trigger.
When the kernel panics, we want to switch that LED to the panic trigger,
so it blinks signalling the panic.

IOW, this allows a LED to be used for "normal operation stuff trigger",
but blink if the kernel panics.
-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-04 22:30 +0200
  Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional  property Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2016-04-05 23:40 +0200
    Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-06 06:40 +0200
  Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Rob Herring <robh@kernel.org> - 2016-04-06 17:20 +0200
    Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-06 18:20 +0200

csiph-web