Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1371978

Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property

From Jacek Anaszewski <jacek.anaszewski@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property
Date 2016-04-05 23:40 +0200
Message-ID <rkGRB-1Og-41@gated-at.bofh.it> (permalink)
References <rkjih-dT-7@gated-at.bofh.it> <rkjij-dT-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Ezequiel,

On 04/04/2016 10:22 PM, Ezequiel Garcia wrote:
> It's desirable to specify which LEDs are to be blinked on a kernel
> panic. Therefore, introduce a devicetree boolean property to mark
> which LEDs should be treated this way.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
>   Documentation/devicetree/bindings/leds/common.txt | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> index 68419843e32f..dd409df9203a 100644
> --- a/Documentation/devicetree/bindings/leds/common.txt
> +++ b/Documentation/devicetree/bindings/leds/common.txt
> @@ -37,6 +37,8 @@ Optional properties for child nodes:
>                        property is mandatory for the LEDs in the non-flash modes
>                        (e.g. torch or indicator).
>
> +- panic-blink : Mark this LED to be used by the panic LED trigger.

I'd say that 'panic-indicator' would be more informative.

Please next time cc also devicetree list and maintainers.

> +
>   Required properties for flash LED child nodes:
>   - flash-max-microamp : Maximum flash LED supply current in microamperes.
>   - flash-max-timeout-us : Maximum timeout in microseconds after which the flash
>

-- 
Best regards,
Jacek Anaszewski

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-04 22:30 +0200
  Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional  property Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2016-04-05 23:40 +0200
    Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-06 06:40 +0200
  Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Rob Herring <robh@kernel.org> - 2016-04-06 17:20 +0200
    Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-06 18:20 +0200

csiph-web