Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1360347 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-03-18 06:50 +0100 |
| Last post | 2016-03-21 21:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[patch] ib_srpt: fix a WARN_ON() message Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-18 06:50 +0100
Re: [patch] ib_srpt: fix a WARN_ON() message Doug Ledford <dledford@redhat.com> - 2016-03-21 21:20 +0100
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-03-18 06:50 +0100 |
| Subject | [patch] ib_srpt: fix a WARN_ON() message |
| Message-ID | <rdVsl-1kZ-11@gated-at.bofh.it> |
The first argument of WARN_ON() is a condition, so it means the warning
message here will just be the name without the ->qp_num information.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 1d13090..0bd3cb2 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct ib_cq *cq, struct ib_wc *wc)
if (srpt_set_ch_state(ch, CH_DISCONNECTED))
schedule_work(&ch->release_work);
else
- WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
+ WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
}
}
[toc] | [next] | [standalone]
| From | Doug Ledford <dledford@redhat.com> |
|---|---|
| Date | 2016-03-21 21:20 +0100 |
| Message-ID | <rfesW-2eY-7@gated-at.bofh.it> |
| In reply to | #1360347 |
[Multipart message — attachments visible in raw view] — view raw
On 3/18/2016 9:17 PM, Bart Van Assche wrote:
> On 03/17/16 22:41, Dan Carpenter wrote:
>> The first argument of WARN_ON() is a condition, so it means the warning
>> message here will just be the name without the ->qp_num information.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> index 1d13090..0bd3cb2 100644
>> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct
>> ib_cq *cq, struct ib_wc *wc)
>> if (srpt_set_ch_state(ch, CH_DISCONNECTED))
>> schedule_work(&ch->release_work);
>> else
>> - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
>> + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
>> }
>> }
>
> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Thanks, applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web