[patch] ib_srpt: fix a WARN_ON() message

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] ib_srpt: fix a WARN_ON() message
Date	2016-03-18 06:50 +0100
Message-ID	<rdVsl-1kZ-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The first argument of WARN_ON() is a condition, so it means the warning
message here will just be the name without the ->qp_num information.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 1d13090..0bd3cb2 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct ib_cq *cq, struct ib_wc *wc)
 		if (srpt_set_ch_state(ch, CH_DISCONNECTED))
 			schedule_work(&ch->release_work);
 		else
-			WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
+			WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
 	}
 }

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] ib_srpt: fix a WARN_ON() message Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-18 06:50 +0100
  Re: [patch] ib_srpt: fix a WARN_ON() message Doug Ledford <dledford@redhat.com> - 2016-03-21 21:20 +0100

csiph-web