Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1362130

Re: [patch] ib_srpt: fix a WARN_ON() message

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 3/18/2016 9:17 PM, Bart Van Assche wrote:
> On 03/17/16 22:41, Dan Carpenter wrote:
>> The first argument of WARN_ON() is a condition, so it means the warning
>> message here will just be the name without the ->qp_num information.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> index 1d13090..0bd3cb2 100644
>> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct
>> ib_cq *cq, struct ib_wc *wc)
>>           if (srpt_set_ch_state(ch, CH_DISCONNECTED))
>>               schedule_work(&ch->release_work);
>>           else
>> -            WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
>> +            WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
>>       }
>>   }
> 
> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>

Thanks, applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] ib_srpt: fix a WARN_ON() message Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-18 06:50 +0100
  Re: [patch] ib_srpt: fix a WARN_ON() message Doug Ledford <dledford@redhat.com> - 2016-03-21 21:20 +0100

csiph-web