Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447834 > unrolled thread

Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-07-21 14:50 +0200
    Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 16:00 +0200

#1447834 — Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

Hello,

On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>  
> 
> Why?  It's not like this is an on-soc device, but most likely a PCIe card.
> Should we build-in all PCIe drivers?

I agree.

> I think it makes more sense to have this as a module rather than built-in.

I would prefer to not have it all in the defconfig. I'd hate to have
a defconfig that builds tons of random modules "just because".

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [next] | [standalone]

#1447901

Hi Russel, Thmoas

2016-07-21 14:46 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Hello,
>
> On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote:
>> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
>> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
>>
>> Why?  It's not like this is an on-soc device, but most likely a PCIe card.
>> Should we build-in all PCIe drivers?
>
> I agree.
>
>> I think it makes more sense to have this as a module rather than built-in.
>
> I would prefer to not have it all in the defconfig. I'd hate to have
> a defconfig that builds tons of random modules "just because".

Both Semihalf and Marvel ISL teams use E1000E NICs with Marvell boards
for development/testing purpose, so we always have to enable it
manually - that's the reason why I wanted to have it enabled by
default.
Nevertheless it is indeed not part of the SoC and I understand your
arguments. I will drop it in the next patch-set version

Thank you,
Grzegorz

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web