Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

From	Grzegorz Jaszczyk <jaz@semihalf.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig
Date	2016-07-21 16:00 +0200
Message-ID	<rXmG6-89V-23@gated-at.bofh.it> (permalink)
References	<rXlAl-7uo-3@gated-at.bofh.it> <rXlAl-7uo-17@gated-at.bofh.it> <rXlAl-7uo-19@gated-at.bofh.it> <rXlAl-7uo-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Russel, Thmoas

2016-07-21 14:46 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Hello,
>
> On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote:
>> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
>> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
>>
>> Why?  It's not like this is an on-soc device, but most likely a PCIe card.
>> Should we build-in all PCIe drivers?
>
> I agree.
>
>> I think it makes more sense to have this as a module rather than built-in.
>
> I would prefer to not have it all in the defconfig. I'd hate to have
> a defconfig that builds tons of random modules "just because".

Both Semihalf and Marvel ISL teams use E1000E NICs with Marvell boards
for development/testing purpose, so we always have to enable it
manually - that's the reason why I wanted to have it enabled by
default.
Nevertheless it is indeed not part of the SoC and I understand your
arguments. I will drop it in the next patch-set version

Thank you,
Grzegorz

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-07-21 14:50 +0200
  Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 16:00 +0200

csiph-web